Errors from wp-hooks in WP 5.0-5.5

[westonruter]

Bug Description

On the Settings Screen and Onboarding Wizard and AMP Customizer, I'm seeing Uncaught TypeError: Cannot read properties of undefined (reading 'wp') in WordPress 5.0-5.5:

Nevertheless, the screens seem to work properly.

This is low priority given the old WP version.

Expected Behaviour

No errors should occur on these screens.

Screenshots

No response

PHP Version

No response

Plugin Version

2.2

AMP plugin template mode

Standard, Transitional, Reader

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

[westonruter]

In WordPress 5.3.10 & 5.4.8, the Customizer has many more errors than just this:

It breaks the Customizer entirely.

[westonruter]

The resolution for the Customizer issue should be just to disable AMP integration in WP<5.6.

Update: See #6773 (comment).

[dhaval-parekh]

While further debugging the issue, Found that while generating polyfill files it assigned the polyfill object into this.wp instead of global wp (or window.wp). This can be changed by removing the below line from the webpack.config.js file.

amp-wp/webpack.config.js

Line 205 in 4cd08b2

libraryTarget: 'this',

Though testing these changes with other features.

[westonruter]

Humm. But that shouldn't matter, should it? It should be that in a browser context, this === window.

[dhaval-parekh]

Yes, ideally this === window by default. But when the function uses strict mode this remains undefined and has to define manually. Reference

[westonruter]

Ah yes, I forgot about strict mode. 👍

[bartoszgadomski]

QA results

AMP plugin version: 2.2.0-RC1-20211210T171412Z-7e67d49

Settings Screen

WordPress version	Screenshot	Description
5.0.3, 5.1.1, 5.2.4, 5.3.2, 5.4.2		REST requests failed for /wp/v2/themes (400: Missing parameter(s): status) and /wp/v2/plugins (404)
5.5.3, 5.6.2		REST request failed for /wp/v2/themes (400: Missing parameter(s): status)
5.7.2		No issues

Onboarding wizzard

WordPress version	Screenshot	Description
5.0.3, 5.1.1, 5.2.4, 5.3.2, 5.4.2		REST requests failed for /wp/v2/themes (400: Missing parameter(s): status) and /wp/v2/plugins (404)
5.5.3, 5.6.2		REST request failed for /wp/v2/themes (400: Missing parameter(s): status)
5.7.2		No issues

CC: @westonruter @delawski

[delawski]

@bartoszgadomski Those issues are fixed in #6773. Since it's not merged yet, I think it's best to wait with the QA until it's in develop.

[delawski]

QA Passed

WordPress Version	QA	AMP Settings	QA	Onboarding Wizard
4.9.8	✅		✅
5.5.7	✅		✅
5.6.6	✅		✅

Version 2.2.0-RC1-20211214T235253Z-fda381f

---

@bartoszgadomski If you have capacity today, please confirm everything works as expected with the latest 2.2 production build.