Site scanning performed multiple times on Onboarding Wizard

[dhaval-parekh]

Bug Description

On the "Onboarding Wizard" after selecting template mode, when we go to the next screen we are saving the AMP options. After saving settings, if we go back to the "Site scan" screen. It will rescan the site even though we already scanned the site.

Since We are forcing standard mode during scanning while on the "Onboarding Wizard". I assume rescanning site will not provide different data.

While it rescans the site the "Next" button is enabled (while during the first scan it was disabled), So users can go to the next/previous screen while scanning is still running. It will lead the "Site scan" screen to perform the site scanning process multiple times.

AMP-site-scanning-onboarding-wizard.mov

Expected Behaviour

• Since We enforcing the standard mode while scanning the site on "Onboarding Wizard", When the user goes back to the "Site scan" screen we should be rescanning the site.
• While site scanning is in progress, the "Next" and "Previous" buttons should be disabled. That way we should be able to prevent multiple requests of site scanning.

Screenshots

No response

PHP Version

No response

Plugin Version

2.2.0-alpha

AMP plugin template mode

Standard, Transitional, Reader

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

[milindmore22]

QA Passed
Next and Previous button/links are disabled while performing Site Scan.

Going back won't rescan the site, but when the user exists Onboarding Wizard, Settings screen scanner will scan the site for newly selected template mode.

[fellyph]

I was testing other task and saw this behavior:

1. go to reopen wizard
2. go until site scan and let the scan run
3. click on close wizard
4. the test runs another time(is this second scan expected ?)

AMP.Settings.amp-beta.WordPress.1.mp4

[westonruter]

4. the test runs another time(is this second scan expected ?)

Yes: This was added in #6683

Also, when landing on the AMP Settings screen after completing the Onboarding Wizard, a scan-if-stale query parameter is added to the URL. If the scan results are stale, a site scan will be initiated automatically and the query parameter will be removed from the URL.

It needs to re-scan on the Settings screen if not in Standard mode since the scan in the Wizard always uses Standard.

[milindmore22]

As noticed by Dhaval, our recent changes might have brought back this issue, I am able to reproduce it.

📹 https://recordit.co/r5KGb0xIj7

[delawski]

I can replicate it as well. Reopening and working on a fix right away.

[delawski]

As per #6791 (comment) and #6791 (review) QA is complete - moving to QA Passed lane.

Actually, the PR isn't merged yet. It has 2 approvals so it is ready for merge and final QA.