Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox gallery always show first image. #6489

Closed
milindmore22 opened this issue Jul 27, 2021 · 3 comments
Closed

Lightbox gallery always show first image. #6489

milindmore22 opened this issue Jul 27, 2021 · 3 comments
Labels
Bug Something isn't working Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency.

Comments

@milindmore22
Copy link
Collaborator

milindmore22 commented Jul 27, 2021

Bug Description

If a page/post has multiple images and all images are opted-in for AMP Lightbox, clicking on any image shows/focus the first image on the page.

Expected Behaviour

The clicked image should be opened up/focused in the lightbox gallery.

Steps to reproduce

  1. Create a Post
  2. Add 3-4 images and Opt-in for Lightbox
  3. Open Same Post's AMP endpoint
  4. Scroll down and click 2nd, 3rd, or 4th image
  5. The first Image shows up.

Screenshots

https://recordit.co/bIdEHsi0gI

Additional context

  • WordPress version: 5.8
  • Plugin version: 2.1.3
  • Gutenberg plugin version (if applicable): not active
  • AMP plugin template mode: Transitional Mode
  • PHP version: 7.4
  • OS: Mac OS Catlina
  • Browser: Chrome
  • Device: MacBook Air

Test URL (it will last for 6 days ): https://particular-copperhead.jurassic.ninja/2021/07/26/image-test-gutenberg-deactivated/amp/


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@milindmore22 milindmore22 added the Bug Something isn't working label Jul 27, 2021
@westonruter
Copy link
Member

westonruter commented Jul 27, 2021

It looks like this may be an issue with AMP core. See ampproject/amphtml#35402.

@westonruter
Copy link
Member

Nevertheless, I don't think the workaround described in ampproject/amphtml#35402 (comment) will work in the plugin because the unused amp-carousel script would get stripped out.

@westonruter westonruter added the Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency. label Jul 27, 2021
@milindmore22
Copy link
Collaborator Author

Closing this as it's fixed in upstream ampproject/amphtml#36103 and we are no longer able to reproduce the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency.
Projects
None yet
Development

No branches or pull requests

2 participants