We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In #4999 we check if the AMP slug (query var) is defined too late and if so, prevent selection of a non-legacy Reader theme:
This, however, was not likewise implemented for the Settings screen which allows all to be selected:
The available themes should be consistent between the Settings screen and the Onboarding Wizard.
Activate this plugin:
<?php /** * Plugin Name: AMP Define Query Var Early with Constant */ add_action( 'after_setup_theme', function () { add_filter( 'amp_query_var', function() { return 'too-early-with-constant'; } ); }, ~PHP_INT_MAX );
Then access the AMP Settings screen and select Reader template mode.
This is part of #4795.
Do not alter or remove anything below. The following sections will be managed by moderators only.
The text was updated successfully, but these errors were encountered:
QA Passed
To test this, I added a plugin that did this:
add_action( 'setup_theme', function () { define( 'AMP_QUERY_VAR', 'lite' ); } );
When doing so, the settings screen shows:
And the Onboarding Wizard:
So the non-legacy Reader themes are indeed prevented from being used.
Sorry, something went wrong.
westonruter
Successfully merging a pull request may close this issue.
Bug Description
In #4999 we check if the AMP slug (query var) is defined too late and if so, prevent selection of a non-legacy Reader theme:
This, however, was not likewise implemented for the Settings screen which allows all to be selected:
Expected Behaviour
The available themes should be consistent between the Settings screen and the Onboarding Wizard.
Steps to reproduce
Activate this plugin:
Then access the AMP Settings screen and select Reader template mode.
This is part of #4795.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: