Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for class AMP_Core_Theme_Sanitizer #3729

Closed
schlessera opened this issue Nov 14, 2019 · 0 comments
Closed

Add tests for class AMP_Core_Theme_Sanitizer #3729

schlessera opened this issue Nov 14, 2019 · 0 comments
Assignees
Labels
Needs Tests P2 Low priority Sanitizers WS:Core Work stream for Plugin core

Comments

@schlessera
Copy link
Collaborator

Feature description

Although we are testing the entire matrix of PHP versions through Travis CI, release 1.4 introduced code that worked on PHP 7.2+ only as part of AMP_Core_Theme_Sanitizer::add_twentytwenty_modals, see #3727.

This shouldn't happen, and it was only possible because we don't have unit tests in place to cover the code in the AMP_Core_Theme_Sanitizer class.

Acceptance criteria

Unit tests cover each of the methods in the code of the AMP_Core_Theme_Sanitizer class, at the very least for the happy path.

Implementation brief

QA testing instructions

Demo

Changelog entry

@kmyram kmyram added the Size: S label Mar 3, 2020
@westonruter westonruter added the P2 Low priority label Apr 12, 2020
@kmyram kmyram added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 5, 2020
@schlessera schlessera added WS:Core Work stream for Plugin core and removed WS:Perf Work stream for Metrics, Performance and Optimizer labels Sep 18, 2020
@github-project-automation github-project-automation bot moved this to Backlog in Ongoing Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests P2 Low priority Sanitizers WS:Core Work stream for Plugin core
Projects
Archived in project
Development

No branches or pull requests

5 participants