Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Color Picker, with Opacity, to Present a Better UX #3182

Closed
MackenzieHartung opened this issue Sep 4, 2019 · 13 comments
Closed

Update Color Picker, with Opacity, to Present a Better UX #3182

MackenzieHartung opened this issue Sep 4, 2019 · 13 comments
Labels
Needs More Info Follow-up required in order to be actionable. UX

Comments

@MackenzieHartung
Copy link

MackenzieHartung commented Sep 4, 2019

Feature description

As a user I want to see a more intuitive/visual dynamic color picker (including opacity) when selecting colors, with opacity option, currently in the editor.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • AC1: A new display of the color picker will be implemented within the editor.
  • AC2: The color picker will include opacity option
  • AC3: The new color picker will display in all areas where color picker, and opacity, currently exist (e.g. page and blocks)

This is closely related to #3068 and #3213

Implementation brief

QA testing instructions

Demo

Changelog entry

@spacedmonkey
Copy link
Contributor

This ticket needs more details. Currently the background options for a page, already has opacity options.

Screenshot from 2019-09-23 12-06-52

What sort of shade options would be required?

@spacedmonkey spacedmonkey added the Needs More Info Follow-up required in order to be actionable. label Sep 23, 2019
@pbakaus
Copy link

pbakaus commented Sep 23, 2019

Jonny, should this work continue per your comment at #3181 (comment), or should we pause this as well?

Re: shades: This refers to shades of primary colors, see Chrome DevTools Colorpicker, where you can long press to bring them up (I worked on this one ;-) ):

image

@cathibosco
Copy link

Regarding opacity in editors - this simple editor is a very useful example as well and may be worth looking at closer. We have used it as a model in other issues like the color palettes mock ups...

You see the results in the page and it has some simple break points that I am not sure about the usability on.
Here is a look:
Screen Capture on 2019-09-23 at 12-44-52

You can open a free account at https://miro.com and experience this.

@cathibosco
Copy link

Here is a low fi sketch of an option of moving the opacity selector up top in the panel so that it is not covered by added palette options... (brain storming here)

It might be useful to see the changes as they happen on the page and not just when you are using the color picker...

Editors have a palette they are working with, select a color and can set the opacity. Preview is live on the page.

AMP Beta - Background Media and Color Layers-palettes-panel-opacity

@cathibosco
Copy link

cathibosco commented Sep 23, 2019

The shade picker above from Chrome dev Tools is nice... I'll keep an eye out for more options on that.

@cathibosco
Copy link

@spacedmonkey
Copy link
Contributor

Some examples of open source color pickers.

https://github.com/loicmahieu/material-ui-color-picker
https://github.com/casesandberg/react-color
https://github.com/react-component/color-picker

The material UI color picker looks the best of the lot.

@spacedmonkey
Copy link
Contributor

React-color seems like the most usable of the packages I tested. material-ui-color-picker seems to based on React Color anyway.

Here is an screenshot of the new colour picker while I was testing. It even includes colors defined in the theme.

Screenshot from 2019-09-24 17-07-17

@spacedmonkey
Copy link
Contributor

Screenshot from 2019-09-24 17-19-07
This slide is also available in react-color

@spacedmonkey
Copy link
Contributor

Screenshot from 2019-09-24 17-26-34
Chrome based color picker also available.

@cathibosco
Copy link

"React-color seems like the most usable of the packages I tested. material-ui-color-picker seems to based on React Color anyway."

This looks very useful @spacedmonkey Nice discovery.

@spacedmonkey
Copy link
Contributor

Interesting fact, gutenberg's color pickers, is based on React color.

@MackenzieHartung MackenzieHartung changed the title Discovery: Color picker with opacity/shade support Update Color Picker, with Opacity, to Present a Better UX Oct 2, 2019
@MackenzieHartung
Copy link
Author

Shade Support was moved to a separate ticket: #3423

@kmyram kmyram added this to the v1.4 milestone Oct 8, 2019
@swissspidy swissspidy removed this from the v1.4 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs More Info Follow-up required in order to be actionable. UX
Projects
None yet
Development

No branches or pull requests

7 participants