-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP plugin validator logs amp-timeago component as an error #2323
Comments
Hi there and thanks for your report! I just quickly tested this on my site and I cannot seem to reproduce this. Perhaps you can give us some more information about this? In particular:
|
I just saw that you reported a similar issue in #2067 before. Mentioning it here for context. Did you make sure to use the component with all the required attributes? |
@pradeep910 All of those validation errors have a Found URL count of “0”. All you need to do is click the “Clear Empty” button and they'll go away. |
In other words, you fixed the error and so that is why there are no URLs on which the error occurs. So now you can just clean up the old references. Eventually we should use WP Cron to clear out empty validation errors like this. See #1415. |
D'oh, I didn't even look at that column 😅 |
@westonruter I still think |
It is a valid component, but if you use it wrongly it will still be an error. |
Yes, I think we were using wrong date format earlier. But that's fixed later. Corrected format -
But since it got fixed later it is showing 0 URLs found. All good! 👍 |
Just wanted to point out that
amp-timeago
is AMP component and works properly on AMP pages. https://amp.dev/documentation/examples/components/amp-timeago/However AMP plugin validator is logging it as an error. See the attachment below.
Should this be an error?
The text was updated successfully, but these errors were encountered: