Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP plugin validator logs amp-timeago component as an error #2323

Closed
pradeep910 opened this issue May 15, 2019 · 8 comments
Closed

AMP plugin validator logs amp-timeago component as an error #2323

pradeep910 opened this issue May 15, 2019 · 8 comments

Comments

@pradeep910
Copy link
Collaborator

Just wanted to point out that amp-timeago is AMP component and works properly on AMP pages. https://amp.dev/documentation/examples/components/amp-timeago/
However AMP plugin validator is logging it as an error. See the attachment below.
Should this be an error?

Screenshot 2019-05-16 at 12 15 05 AM

@swissspidy
Copy link
Collaborator

Hi there and thanks for your report!

I just quickly tested this on my site and I cannot seem to reproduce this. Perhaps you can give us some more information about this? In particular:

  • Which version of the plugin are you using
  • Which mode are you using (classic/reader, paired/transitional, or native)
  • How did you insert the amp-timeago component and what content did you put into it
  • What error details are shown when you expand the errors to show details

@swissspidy
Copy link
Collaborator

I just saw that you reported a similar issue in #2067 before. Mentioning it here for context. Did you make sure to use the component with all the required attributes?

@westonruter
Copy link
Member

@pradeep910 All of those validation errors have a Found URL count of “0”. All you need to do is click the “Clear Empty” button and they'll go away.

@westonruter
Copy link
Member

In other words, you fixed the error and so that is why there are no URLs on which the error occurs. So now you can just clean up the old references. Eventually we should use WP Cron to clear out empty validation errors like this. See #1415.

@swissspidy
Copy link
Collaborator

D'oh, I didn't even look at that column 😅

@pradeep910
Copy link
Collaborator Author

@westonruter I still think amp-timeago should not be part of error list as its valid AMP component. So if we don't log this error, we don't have to use WP Cron to clear out empty validation errors of this component.

@swissspidy
Copy link
Collaborator

It is a valid component, but if you use it wrongly it will still be an error.

@pradeep910
Copy link
Collaborator Author

Yes, I think we were using wrong date format earlier. But that's fixed later.

Screenshot 2019-05-17 at 8 02 25 PM

Corrected format -

<amp-timeago width="100" height="22" layout="responsive" class="gk-date-diff" datetime="2019-05-17T16:31:05+05:30" cutoff="2592000">May 17, 2019, 4:31 PM</amp-timeago>  

But since it got fixed later it is showing 0 URLs found.

All good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants