Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg lagging and high CPU usage when in paired mode #1679

Closed
asadkn opened this issue Nov 30, 2018 · 8 comments
Closed

Gutenberg lagging and high CPU usage when in paired mode #1679

asadkn opened this issue Nov 30, 2018 · 8 comments
Labels
Bug Something isn't working P0 High priority
Milestone

Comments

@asadkn
Copy link

asadkn commented Nov 30, 2018

When AMP is in paired mode, there's massive lag when using Gutenberg demo post. I have tried this with twentyseventeen theme, and Gutenberg + AMP RC3 plugins active. The problem doesn't occur with default settings but only when paired mode is activated via functions.php:

		// Add support 
		add_theme_support('amp', array(
			'paired' => true
		));

Screencast: https://d.pr/v/HLB3BN

@westonruter westonruter added this to the v1.0 milestone Nov 30, 2018
@lkraav
Copy link

lkraav commented Nov 30, 2018

Looks very similar to what's happening in WordPress/gutenberg#12312 and the underlying issues there.

@westonruter
Copy link
Member

@miina Would you test if this Gutenberg PR fixes the problem?

@miina
Copy link
Contributor

miina commented Nov 30, 2018

@westonruter Sure, testing now.

@miina
Copy link
Contributor

miina commented Nov 30, 2018

@westonruter Testing locally with a long post on that PR branch: typing is very slow in both Paired and Native mode. With classic mode it seems to be the "normal" experience of Gutenberg. Switched these a few times just in case to make sure it was related to switching the mode and it seemed to be the same every time -- very slow typing in Native / Paired mode.

@westonruter westonruter added Bug Something isn't working P0 High priority labels Nov 30, 2018
@westonruter
Copy link
Member

That's not good! I wonder if it is due to AMP block extensions, or if it is due to the AMP block validation code. Please try disabling one or the other to see if you can narrow down where the problem is.

@kienstra
Copy link
Contributor

kienstra commented Nov 30, 2018

Request To Test PR

Hi @asadkn,
Thanks a lot for bringing up this issue.

Could you please test #1682 to see if it fixes this for you? It worked for me locally.

It looks like you know how this works, but please do npm run dev from the plugin root to rebuild the JavaScript files.

@asadkn
Copy link
Author

asadkn commented Nov 30, 2018

Seems to be all good 👍

@westonruter
Copy link
Member

Merged into 1.0 branch. Will be part of 1.0-RC4. @asadkn Thank you very much for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P0 High priority
Projects
None yet
Development

No branches or pull requests

5 participants