-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Optimizer with transformer for module/nomodule scripts (ESM) #20
Comments
This work should also include preloading of critical modules, either within the same transformer or a separate one. See https://developers.google.com/web/updates/2017/12/modulepreload |
The draft PR ampproject/amp-wp#5078 needs to be transferred over to this repository. |
Please note that the AMP Performance WG does not yet recommend the usage of Would prefer this change does not use |
Note that |
@sebastianbenz Should we be going live in WP with |
There was a recent regression in preload when used with module scripts in Chromium. Engineers on the V8 team are working to address, and as a temporary measure we've elected to use modulepreload on the Google AMP Cache. This carries a downside, as Safari will not process these directives. Until this is resolved, modulepreload is the best of the bad options. |
Feature description
See ampproject/amp-toolbox#722.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: