Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set _inForeground value earlier #433

Merged
merged 8 commits into from
May 26, 2023
Merged

fix: set _inForeground value earlier #433

merged 8 commits into from
May 26, 2023

Conversation

falconandy
Copy link
Contributor

@falconandy falconandy commented Apr 5, 2023 •
edited
Loading

Summary

The fix should fix the issue with sessions spanning across days.

See comments in ticket.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@falconandy falconandy marked this pull request as ready for review April 5, 2023 13:22
@falconandy falconandy requested a review from yuhao900914 April 8, 2023 05:11
justin-fiedler
justin-fiedler reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change makes sense, but I am concerned since we have not been able to reproduce or test this.

@falconandy falconandy requested a review from qingzhuozhen April 14, 2023 13:14
qingzhuozhen
qingzhuozhen approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@qingzhuozhen qingzhuozhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, would like @justin-fiedler to confirm as well

Sources/Amplitude/Amplitude.m Show resolved Hide resolved
@justin-fiedler justin-fiedler merged commit 3cee4c2 into main May 26, 2023
@justin-fiedler justin-fiedler deleted the DXOC-702-sessions-spanning-across-days branch May 26, 2023 23:13
github-actions bot pushed a commit that referenced this pull request May 30, 2023
@amplitude-sdk-bot
chore(release): 8.16.1 [skip ci]
b951260 
## [8.16.1](v8.16.0...v8.16.1) (2023-05-30)

### Bug Fixes

* set _inForeground value earlier ([#433](#433)) ([3cee4c2](3cee4c2))
* sudo rm appledoc ([#444](#444)) ([53ba490](53ba490))
* XCode 14 fixes - update iPhone targets to 11, MacOS to 10.15, appledoc ([#442](#442)) ([5c15979](5c15979))
@github-actions
Copy link

🎉 This PR is included in version 8.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@falconandy @justin-fiedler @yuhao900914 @qingzhuozhen