fix: enable the remote ip #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoliu-amp
approved these changes
Sep 22, 2022
qingzhuozhen
approved these changes
Sep 22, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
## [1.3.2](v1.3.1...v1.3.2) (2022-09-22) ### Bug Fixes * enable the remote ip ([#75](#75)) ([232620c](232620c))
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In android SDK the IP address can be get on the server side.
The old android SDK is using the HTTP API v1. We don't need to set anything in order to use the remote IP. https://github.com/amplitude/amplitude/blob/master/event/converters/sdk.py#L164
But the Kotlin SDK is using the HTTP API V2, which required to pass
ip="$remote"https://github.com/amplitude/amplitude/blob/master/event/converters/http_event.py#L528.In order to fix the IP is null in kotlin SDK we need to pass the
ip="$remote".Checklist