fix: invalid json array string for android file storage #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
approved these changes
Jul 27, 2022
|
@liuyang1520 I found two cases in the issue report, one is file already exist but empty, another is missing comma between start_session and end_session events. Still don't know what really caused the second one. But by check file length I think we can cover both cases. |
qingzhuozhen
approved these changes
Jul 27, 2022
yuhao900914
reviewed
Jul 27, 2022
yuhao900914
approved these changes
Jul 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
# [1.1.0](v1.0.1...v1.1.0) (2022-07-29) ### Bug Fixes * authorize for release action ([#47](#47)) ([5c44d34](5c44d34)) * invalid json array string for android file storage ([#50](#50)) ([593050a](593050a)) ### Features * add reset method to reset userId and deviceId ([#48](#48)) ([837895a](837895a))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix unterminated array
fix expected literal value at character 0
Checklist