Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added deviceId to Configuration options #178

Conversation

justin-fiedler
Copy link
Contributor

Summary

Adds deviceId to Configuration options to set the initial deviceId (instead of generating it, or reading from storage)

val deviceId = "test device id"
val amplitude = Amplitude(Configuration(deviceId = deviceId))
amplitude.isBuilt.invokeOnCompletion {
    assertEqual(deviceId, amplitude.getDeviceId());
}

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@justin-fiedler justin-fiedler merged commit 45b6181 into main Jan 30, 2024
2 checks passed
@justin-fiedler justin-fiedler deleted the AMP-85977-auto-generated-device-id-instead-of-custom-device-id-android branch January 30, 2024 22:57
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
# [1.14.0](v1.13.0...v1.14.0) (2024-01-30)

### Bug Fixes

* race condition when setting device id in android ([#177](#177)) ([671edb9](671edb9))

### Features

* added deviceId to Configuration options ([#178](#178)) ([45b6181](45b6181))
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants