Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event options should override event properties, refresh last event time on exit foreground #122

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: event options should override event properties, refresh last event time on exit foreground #122

merged 1 commit into from
May 18, 2023

Conversation

falconandy
Copy link
Contributor

Summary

  1. Event options override event properties
  2. sessionId is nullable now in event/options.
  3. Refresh last event time on exit foreground.
  4. Copied session-related tests from Amplitude-Swift.
  5. Introduced internal dummy event types (enter foreground, exit foreground) instead of possibly valid session_start/session_end events with null sessionId.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@falconandy falconandy requested a review from justin-fiedler May 17, 2023 11:32
justin-fiedler
justin-fiedler approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @falconandy. Tests are great. I like the new dummy foreground background events. Make the logic more clear.

@justin-fiedler justin-fiedler merged commit 652ea42 into main May 18, 2023
@justin-fiedler justin-fiedler deleted the AMP-75272-event-options-should-override-event-properties branch May 18, 2023 19:31
github-actions bot pushed a commit that referenced this pull request May 26, 2023
@amplitude-sdk-bot
chore(release): 1.9.0 [skip ci]
d10bce6 
# [1.9.0](v1.8.2...v1.9.0) (2023-05-26)

### Bug Fixes

* event options should override event properties, refresh last event time on exit foreground ([#122](#122)) ([652ea42](652ea42))

### Features

* add remnant events migration plugin ([#40](#40)) ([6225f5d](6225f5d))
@github-actions
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falconandy @justin-fiedler