feat: update retry handling #113

qingzhuozhen · 2023-03-30T05:53:28Z

Summary

update retry strategy to use exponential back off
stop sending data after max retries
add integration tests

Checklist

Does your PR title have the correct title format?
Does your PR have a breaking change?: no

core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt

core/src/test/kotlin/com/amplitude/core/IdentifyInterceptTest.kt

yuhao900914 · 2023-03-31T18:57:36Z

@qingzhuozhen , can you add more content to the description to explain the original issue? Thanks.

core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt

core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt

core/src/main/java/com/amplitude/core/Storage.kt

android/src/test/java/com/amplitude/android/ResponseHandlerTest.kt

core/src/main/java/com/amplitude/core/Configuration.kt

core/src/main/java/com/amplitude/core/utilities/Response.kt

core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt

justin-fiedler

LGTM. Can you please fix the disabled tests?

# [1.8.0](v1.7.1...v1.8.0) (2023-04-10) ### Bug Fixes * filter null values in identify intercept ([#116](#116)) ([3689fc1](3689fc1)) ### Features * update retry handling ([#113](#113)) ([1020acd](1020acd))

github-actions · 2023-04-10T21:21:45Z

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

GitHub release
v1.8.0

Your semantic-release bot 📦🚀

feat: update retry handling

4fdc536

qingzhuozhen commented Mar 30, 2023

View reviewed changes

core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt Show resolved Hide resolved

qingzhuozhen added 10 commits March 29, 2023 23:12

resolve test

0af8da3

try remove test dependency

7355bed

add test dependency back

0f05b2f

fix some warnings

00c5bba

update

6a58db9

test

93b77f4

update

ba2a4fc

try update os

e04eb8c

temporarily disable the test

bdba994

fix ktlint

0189e83

qingzhuozhen commented Mar 30, 2023

View reviewed changes

core/src/test/kotlin/com/amplitude/core/IdentifyInterceptTest.kt Show resolved Hide resolved

qingzhuozhen requested review from justin-fiedler and yuhao900914 March 30, 2023 23:53

yuhao900914 reviewed Apr 4, 2023

View reviewed changes

core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt Show resolved Hide resolved

core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt Show resolved Hide resolved

core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt Show resolved Hide resolved

justin-fiedler reviewed Apr 5, 2023

View reviewed changes

qingzhuozhen added 2 commits April 5, 2023 14:11

add more comments

15cdd5d

fix lint

e525413

qingzhuozhen requested review from yuhao900914 and justin-fiedler April 5, 2023 23:15

yuhao900914 approved these changes Apr 7, 2023

View reviewed changes

justin-fiedler approved these changes Apr 7, 2023

View reviewed changes

qingzhuozhen merged commit 1020acd into main Apr 10, 2023

qingzhuozhen deleted the update-backoff-retry branch April 10, 2023 20:52

github-actions bot added the released label Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update retry handling #113

feat: update retry handling #113

qingzhuozhen commented Mar 30, 2023 •

edited

Loading

yuhao900914 commented Mar 31, 2023

justin-fiedler left a comment

github-actions bot commented Apr 10, 2023

feat: update retry handling #113

feat: update retry handling #113

Conversation

qingzhuozhen commented Mar 30, 2023 • edited Loading

Summary

Checklist

yuhao900914 commented Mar 31, 2023

justin-fiedler left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 10, 2023

qingzhuozhen commented Mar 30, 2023 •

edited

Loading