Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On “b_min” computation. #26

Open
KelSolaar opened this issue Mar 17, 2021 · 1 comment
Open

On “b_min” computation. #26

KelSolaar opened this issue Mar 17, 2021 · 1 comment

Comments

@KelSolaar
Copy link
Collaborator

I reckon that if we pass b_min directly, we should so it everywhere consistently with a comment explaining what it is or we should compute it explicitly.

It is also worth noting that Colour's code already normalises the white balance multipliers, so b_min is not even strictly required.

@nick-shaw
Copy link
Collaborator

Indeed. Since b_min is currently always 1.0, there is a good argument for removing it entirely. Unless we remove the normalisation from Colour, or make it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants