Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix start command in the readme #5

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Mar 8, 2021

No description provided.

@amoutonbrady amoutonbrady merged commit 79165cd into solidjs:master Mar 8, 2021
@amoutonbrady
Copy link
Member

Ah, thank you! I generally prefer the dev script but in order to stay consistent with create-solid-app, I left the start script on the default vite js/ts template.

@aminya
Copy link
Contributor Author

aminya commented Mar 8, 2021

Start actually starts a server, so it makes sense.

I think "dev" should be left for "watch" mode. It is not added yet:
vitejs/vite#1434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants