Resolve user alias config #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry to get back to you so late, I somehow didn't get the notice.. I think this is reasonable. A prior version of the plugin actually had a deepMerge function but I thought vite implemented it themselves at some point. I guess it's time to re-introduce a deepMerge function, To prevent any further override whatsoever, In the meantime this should probably suffice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there is an issue, with how alias config is merged by the vite. If the user used object format to set
alias, vite will override it when merging the plugin config.Not totally sure, if this should be the responsibility of the plugin or a vite itself.