Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant textContent = '' for HMR since as of solid 0.21.0 it's handled by dom expressions #1

Merged
merged 1 commit into from
Nov 23, 2020
Merged

remove redundant textContent = '' for HMR since as of solid 0.21.0 it's handled by dom expressions #1

merged 1 commit into from
Nov 23, 2020

Conversation

boogerlad
Copy link
Contributor

No description provided.

amoutonbrady
amoutonbrady approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@amoutonbrady amoutonbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I did reflect the changes in my Snowpack template but I forgot to update the vite ones. Will do a release right away

@amoutonbrady amoutonbrady merged commit 1261690 into solidjs:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoutonbrady amoutonbrady amoutonbrady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boogerlad @amoutonbrady