Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

199 frontend module refactor homepage design #200

Merged
merged 8 commits into from
Dec 28, 2024

Conversation

flo0852
Copy link
Contributor

@flo0852 flo0852 commented Dec 27, 2024

No description provided.

Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
…iew page

Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
…iew page

Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
Signed-off-by: Florian Oberndörfer <florian8751t@gmail.com>
@flo0852 flo0852 self-assigned this Dec 27, 2024
Copy link
Contributor

@chrisklg chrisklg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue is running, so far everything is working well.
i would rename the overviewpage component to dashboard, as it is our dashboard. but everyone feels differently. i don't think the design with the panel ‘about this page’ fits well there, something like that belongs in the footer but not on a huge landing page. but that could be discussed again in the next meeting.

@chrisklg chrisklg merged commit dd8a303 into dev Dec 28, 2024
3 checks passed
@flo0852
Copy link
Contributor Author

flo0852 commented Dec 28, 2024

the issue is running, so far everything is working well. i would rename the overviewpage component to dashboard, as it is our dashboard. but everyone feels differently. i don't think the design with the panel ‘about this page’ fits well there, something like that belongs in the footer but not on a huge landing page. but that could be discussed again in the next meeting.

About the naming. I thought that the POs mentioned that there will be a subpage that will show the diagrams and I thought, that this subpage should therefore be named dashboard.
About the "About this page" panel. I was also unsure. That's why I asked into the chat. But after not getting an answer for about almost one week, I just did it like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants