Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install ESLint when building next.js application #151

Closed
vringar opened this issue Jun 13, 2023 · 1 comment · Fixed by #159
Closed

Install ESLint when building next.js application #151

vringar opened this issue Jun 13, 2023 · 1 comment · Fixed by #159
Assignees
@vringar
Labels
bug Something isn't working
Milestone
Sprint 10

Comments

@vringar
Copy link
Contributor

vringar commented Jun 13, 2023

Describe the bug

In our current Explorer/Dockerfile we only install non-dev dependencies, this leads to the following error

#15 9.918 - error ESLint must be installed in order to run during builds: npm install --save-dev eslint

To Reproduce
Run

PROGRESS_NO_TRUNC=1 docker build --progress plain --no-cache .

in the Explorer folder and

amos2023ss04-kubernetes-inventory-taker/Explorer/Dockerfile

Line 15 in 816d31e

RUN npm run build

will cause the error you see mentioned above.

Expected behavior
I expect the build step to not emit any error messages.
@jandegen jandegen added the bug Something isn't working label Jun 14, 2023
@jandegen jandegen moved this to Product Backlog in amos2023ss04-feature-board Jun 14, 2023
@jandegen jandegen added this to the Sprint 09 milestone Jun 14, 2023
@jandegen jandegen moved this from Product Backlog to Sprint Backlog in amos2023ss04-feature-board Jun 14, 2023
@vringar vringar mentioned this issue Jun 14, 2023
Merged
@vringar vringar moved this from Sprint Backlog to Awaiting Review in amos2023ss04-feature-board Jun 14, 2023
@vringar vringar self-assigned this Jun 15, 2023
@jandegen jandegen moved this from Awaiting Review to Product Backlog in amos2023ss04-feature-board Jun 21, 2023
@PhlppKrmr PhlppKrmr moved this from Product Backlog to Sprint Backlog in amos2023ss04-feature-board Jun 21, 2023
@vringar vringar moved this from Sprint Backlog to Awaiting Review in amos2023ss04-feature-board Jun 26, 2023
@vringar
Copy link
Contributor Author

vringar commented Jun 26, 2023

Has been merged two weeks ago

@PhlppKrmr PhlppKrmr modified the milestones: Sprint 09, Sprint 10 Jun 27, 2023
@jandegen jandegen moved this from Awaiting Review to Feature Archive in amos2023ss04-feature-board Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vringar vringar

Labels
bug Something isn't working
Projects
amos2023ss04-feature-board
Status: Feature Archive
Milestone
Sprint 10
3 participants
@vringar @PhlppKrmr @jandegen