Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate data from SimaPro into the graphs #82

Closed
11 tasks done
MichaelScheiderer opened this issue Jun 2, 2021 · 3 comments
Closed
11 tasks done

Integrate data from SimaPro into the graphs #82

MichaelScheiderer opened this issue Jun 2, 2021 · 3 comments
Assignees
Labels

Comments

@MichaelScheiderer
Copy link
Collaborator

MichaelScheiderer commented Jun 2, 2021

User story

  1. As a salesperson
  2. I need to visualize and show to my customers what was calculated in SimaPro
  3. So that I can convince my customer to decide for a product which reduces CO2 impact

Acceptance criteria

Definition of done

  • Documentation for the feature is done
  • Feature branch has been merged
  • Code has been reviewed by at least one other team member
  • Unit tests are written
@Waldleufer
Copy link
Collaborator

@SaiVarunVaranasi @ScoutAtlas and @Waldleufer tried to make that work, but the data we get and the data we want to display seems incompatible. Crosspost from Slack:

@Waldleufer
Copy link
Collaborator

We currently get a lot of data:

image (3)

And the problem we are having is:

By using the function to get the data (https://amosproject8.slack.com/archives/C020MFC5AU8/p1623138797001700) we get a lot of data (60.000 lines of data Computation takes about 10s on the SimaPro Server) and still the data that is required to fill the tables, that we should use is missing.

  • There is a huge discrepancy between the data we get and the data we want to display. There does not seem to be a uniform naming, so we can't reliably link the data each time.
  • That means in particular that we don't have a way to get the Material Composition (We would have to search through all data and somehow determine what is a material and what not, since everything is in one big table)
  • We can not get the data for the impact assessment: Materials, Manufactoring and Transport and operation, and we would have to guess for what data is required for the End of Life at this point.
  • The data for the requested table is a very good example for our problem: (See second screenshot attached) also: We only can get the total values for these, so only column 1 in our table would be fillable with this data.

Screenshot 2021-06-10 153727

SaiVarunVaranasi added a commit that referenced this issue Jun 20, 2021
SaiVarunVaranasi added a commit that referenced this issue Jun 21, 2021
Waldleufer added a commit that referenced this issue Jun 22, 2021
Distribution of last Sprints changes

Co-authored-by: Julian Oelhaf <julian.oelhaf@posteo.de>
Co-authored-by: Sai Varun Varanasi <varun.sai.varanasi@fau.de>
Waldleufer added a commit that referenced this issue Jun 22, 2021
Distribution of new features

Co-authored-by: Sai Varun Varanasi <varun.sai.varanasi@fau.de>
Co-authored-by: Julian Oelhaf <julian.oelhaf@posteo.de>
@MartinDuersch
Copy link
Collaborator

Waldleufer added a commit that referenced this issue Jun 23, 2021
Updating dev-#82 with the current state
manifau added a commit that referenced this issue Jun 24, 2021
Regarding task #82

Co-authored-by: Sai Varun Varanasi <varun.sai.varanasi@fau.de>
ScoutAtlas added a commit that referenced this issue Jun 24, 2021
Regarding #82
Created new file to only do the "calculations", rather it extracts the data from the huge arrays we are recieving.
Thus removed all the calculations from the BackendConnect.
! Implemented callback funtion, which calls the setState in the DetailsComponent. With that we can display the LoadingComponent, while waiting for the backend data.
Once the postCalculationRequest is finished, we call the callback funtion defined in DetailsComponent, which sets the stillLoading variable to false.
React components automatically retrigger the render function if the state is changed.
Removed all the stillLoading stuff in the charts and tables.
ScoutAtlas added a commit that referenced this issue Jun 24, 2021
Regarding #82
Fixed the table and chart components
Fixed the getter Methods
SaiVarunVaranasi added a commit that referenced this issue Jun 28, 2021
#82 the details page displays data from API...
SaiVarunVaranasi added a commit that referenced this issue Jun 29, 2021
distributing code from branch Dev #82
Waldleufer added a commit that referenced this issue Jun 30, 2021
Waldleufer added a commit that referenced this issue Jun 30, 2021
Implementation of #82 - Integrate Data into Graphs


Co-authored-by: Julian Oelhaf <julian.oelhaf@posteo.de>
@gandompm gandompm removed their assignment Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants