Skip to content

Commit 0db0831

Browse files
liaoxin01amorynan
authored andcommitted
[Opt](load) Optimize the error messages of -235 and -238 for loading (apache#41048)
1 parent f8c012b commit 0db0831

5 files changed

+19
-9
lines changed

be/src/cloud/cloud_delete_task.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,10 @@ Status CloudDeleteTask::execute(CloudStorageEngine& engine, const TPushReq& requ
5252
LOG_WARNING("tablet exceeds max version num limit")
5353
.tag("limit", config::max_tablet_version_num)
5454
.tag("tablet_id", tablet->tablet_id());
55-
return Status::Error<TOO_MANY_VERSION>("too many versions, versions={} tablet={}",
56-
config::max_tablet_version_num, tablet->tablet_id());
55+
return Status::Error<TOO_MANY_VERSION>(
56+
"too many versions, versions={} tablet={}. Please reduce the frequency of loading "
57+
"data or adjust the max_tablet_version_num in be.conf to a larger value.",
58+
config::max_tablet_version_num, tablet->tablet_id());
5759
}
5860

5961
// check delete condition if push for delete

be/src/cloud/cloud_rowset_builder.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ Status CloudRowsetBuilder::check_tablet_version_count() {
9292
if (version_count > config::max_tablet_version_num) {
9393
return Status::Error<TOO_MANY_VERSION>(
9494
"failed to init rowset builder. version count: {}, exceed limit: {}, "
95-
"tablet: {}",
95+
"tablet: {}. Please reduce the frequency of loading data or adjust the "
96+
"max_tablet_version_num in be.conf to a larger value.",
9697
version_count, config::max_tablet_version_num, _tablet->tablet_id());
9798
}
9899
return Status::OK();

be/src/olap/push_handler.cpp

+5-2
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,9 @@ Status PushHandler::_do_streaming_ingestion(TabletSharedPtr tablet, const TPushR
163163
// check if version number exceed limit
164164
if (tablet->exceed_version_limit(config::max_tablet_version_num)) {
165165
return Status::Status::Error<TOO_MANY_VERSION>(
166-
"failed to push data. version count: {}, exceed limit: {}, tablet: {}",
166+
"failed to push data. version count: {}, exceed limit: {}, tablet: {}. Please "
167+
"reduce the frequency of loading data or adjust the max_tablet_version_num in "
168+
"be.conf to a larger value.",
167169
tablet->version_count(), config::max_tablet_version_num, tablet->tablet_id());
168170
}
169171

@@ -172,7 +174,8 @@ Status PushHandler::_do_streaming_ingestion(TabletSharedPtr tablet, const TPushR
172174
config::tablet_meta_serialize_size_limit) {
173175
return Status::Error<TOO_MANY_VERSION>(
174176
"failed to init rowset builder. meta serialize size : {}, exceed limit: {}, "
175-
"tablet: {}",
177+
"tablet: {}. Please reduce the frequency of loading data or adjust the "
178+
"max_tablet_version_num in be.conf to a larger value.",
176179
tablet->avg_rs_meta_serialize_size() * version_count,
177180
config::tablet_meta_serialize_size_limit, tablet->tablet_id());
178181
}

be/src/olap/rowset/beta_rowset_writer.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,8 @@ Status BaseBetaRowsetWriter::_check_segment_number_limit(size_t segnum) {
925925
if (UNLIKELY(segnum > config::max_segment_num_per_rowset)) {
926926
return Status::Error<TOO_MANY_SEGMENTS>(
927927
"too many segments in rowset. tablet_id:{}, rowset_id:{}, max:{}, "
928-
"_num_segment:{}, rowset_num_rows:{}",
928+
"_num_segment:{}, rowset_num_rows:{}. Please check if the bucket number is too "
929+
"small or if the data is skewed.",
929930
_context.tablet_id, _context.rowset_id.to_string(),
930931
config::max_segment_num_per_rowset, _num_segment, get_rowset_num_rows());
931932
}
@@ -938,7 +939,8 @@ Status BetaRowsetWriter::_check_segment_number_limit(size_t segnum) {
938939
if (UNLIKELY(segnum > config::max_segment_num_per_rowset)) {
939940
return Status::Error<TOO_MANY_SEGMENTS>(
940941
"too many segments in rowset. tablet_id:{}, rowset_id:{}, max:{}, _num_segment:{}, "
941-
"_segcompacted_point:{}, _num_segcompacted:{}, rowset_num_rows:{}",
942+
"_segcompacted_point:{}, _num_segcompacted:{}, rowset_num_rows:{}. Please check if "
943+
"the bucket number is too small or if the data is skewed.",
942944
_context.tablet_id, _context.rowset_id.to_string(),
943945
config::max_segment_num_per_rowset, _num_segment, _segcompacted_point,
944946
_num_segcompacted, get_rowset_num_rows());

be/src/olap/rowset_builder.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,8 @@ Status RowsetBuilder::check_tablet_version_count() {
165165
if (version_count > config::max_tablet_version_num) {
166166
return Status::Error<TOO_MANY_VERSION>(
167167
"failed to init rowset builder. version count: {}, exceed limit: {}, "
168-
"tablet: {}",
168+
"tablet: {}. Please reduce the frequency of loading data or adjust the "
169+
"max_tablet_version_num in be.conf to a larger value.",
169170
version_count, config::max_tablet_version_num, _tablet->tablet_id());
170171
}
171172
return Status::OK();
@@ -200,7 +201,8 @@ Status RowsetBuilder::init() {
200201
config::tablet_meta_serialize_size_limit) {
201202
return Status::Error<TOO_MANY_VERSION>(
202203
"failed to init rowset builder. meta serialize size : {}, exceed limit: {}, "
203-
"tablet: {}",
204+
"tablet: {}. Please reduce the frequency of loading data or adjust the "
205+
"max_tablet_version_num in be.conf to a larger value.",
204206
tablet()->avg_rs_meta_serialize_size() * version_count,
205207
config::tablet_meta_serialize_size_limit, _tablet->tablet_id());
206208
}

0 commit comments

Comments
 (0)