Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amilajack/eslint-plugin-flowtype-errors
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.6.0
Choose a base ref
...
head repository: amilajack/eslint-plugin-flowtype-errors
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.0
Choose a head ref

Commits on Jul 26, 2018

  1. Copy the full SHA
    d765ab2 View commit details

Commits on Aug 29, 2018

  1. Update dependencies to enable Greenkeeper 🌴 (#126)

    * chore(package): update dependencies
    
    * docs(readme): add Greenkeeper badge
    greenkeeper[bot] authored and amilajack committed Aug 29, 2018
    Copy the full SHA
    6ee0912 View commit details
  2. New config lookup (#125)

    * Breaking change: New config lookup
    
    * Fix tests
    
    * Increase test timeout
    
    * Don't strip eof (for now)
    jdmota authored and amilajack committed Aug 29, 2018
    Copy the full SHA
    7015fc7 View commit details
  3. bumped deps (#127)

    * bumpd deps, update infra
    
    * misc
    
    * Update flowconfig
    amilajack authored Aug 29, 2018
    Copy the full SHA
    1e03814 View commit details
  4. Copy the full SHA
    9a0eb83 View commit details

Commits on Oct 5, 2018

  1. Add renovate.json (#129)

    renovate[bot] authored and amilajack committed Oct 5, 2018
    Copy the full SHA
    ad10a5f View commit details
  2. Remove greenkeeper badge

    amilajack authored Oct 5, 2018
    Copy the full SHA
    99de0e7 View commit details

Commits on Dec 7, 2018

  1. Update renovate.json

    amilajack authored Dec 7, 2018
    Copy the full SHA
    b68f8e4 View commit details

Commits on Feb 23, 2019

  1. Update flow (#158)

    Also remove the caret `^` from the version in package.json because snapshot tests need to use the same version of Flow to be consistent.
    nwoltman authored and amilajack committed Feb 23, 2019
    Copy the full SHA
    571335d View commit details
  2. Copy the full SHA
    04bce8f View commit details
  3. initial migration to azure (#160)

    * initial migration to azure
    
    * update repo badge
    
    * simplify and update azure config
    
    * upgrade babel and all other infra
    amilajack authored Feb 23, 2019
    Copy the full SHA
    78156c9 View commit details
  4. v4.0.0-0

    amilajack committed Feb 23, 2019
    Copy the full SHA
    84e4f90 View commit details
  5. Update README.md

    amilajack authored Feb 23, 2019
    Copy the full SHA
    9fa926a View commit details
  6. Copy the full SHA
    3421bcf View commit details

Commits on Feb 24, 2019

  1. Fix Flow >= v0.71 on Windows (#163)

    Starting in Flow v0.71, Flow will hang forever on Windows when a Flow server is started with `flow check-contents`. This fix prevents Flow from hanging by manually starting the Flow server with `flow start` before the `flow check-contents` call.
    nwoltman authored and amilajack committed Feb 24, 2019
    Copy the full SHA
    6388bf5 View commit details
  2. v4.0.0-1

    amilajack committed Feb 24, 2019
    Copy the full SHA
    ea28d93 View commit details
  3. add Patreon link to readme

    amilajack authored Feb 24, 2019
    Copy the full SHA
    8f66ba9 View commit details
  4. fix broken plugin export (#164)

    * fix broken plugin export
    
    * add "yarn test" to pre-commit hooks
    amilajack authored Feb 24, 2019
    Copy the full SHA
    3ee024d View commit details
  5. Update Settings docs (#165)

    Document the `stopOnExit` setting and remove documentation for the `flowDir` setting (which was removed).
    nwoltman authored and amilajack committed Feb 24, 2019
    Copy the full SHA
    35bdd25 View commit details
  6. v4.0.0-2

    amilajack committed Feb 24, 2019
    Copy the full SHA
    dc55df3 View commit details
  7. updated CHANGELOG

    amilajack committed Feb 24, 2019
    Copy the full SHA
    2697646 View commit details
  8. v4.0.0

    amilajack committed Feb 24, 2019
    Copy the full SHA
    d887728 View commit details

Commits on Mar 2, 2019

  1. Update babel monorepo

    renovate-bot authored and renovate[bot] committed Mar 2, 2019
    Copy the full SHA
    dbb510b View commit details
  2. Copy the full SHA
    edb7b1e View commit details

Commits on Mar 22, 2019

  1. add recommended eslint config (#170)

    * add recommended eslint config
    
    * fix exports bugs
    
    * update CHANGELOG
    
    * add demo to related links
    amilajack authored Mar 22, 2019
    Copy the full SHA
    a8e75f8 View commit details
  2. v4.1.0

    amilajack committed Mar 22, 2019
    Copy the full SHA
    f2898b1 View commit details
14 changes: 0 additions & 14 deletions .babelrc

This file was deleted.

38 changes: 0 additions & 38 deletions .eslintrc

This file was deleted.

2 changes: 1 addition & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[ignore]
.*/node_modules/fbjs/.*
.*/git/.*
.*/test/codebases/.*
.*/test/.*\.example\.js

[options]
suppress_comment=.*\\$FlowIgnore
esproposal.class_static_fields=enable
esproposal.class_instance_fields=enable
esproposal.export_star_as=enable
25 changes: 0 additions & 25 deletions .travis.yml

This file was deleted.

13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
## v4.1.0
### Added
- Recommended config 🎉

## v4.0.0
### Fixed
- Fix Flow `>= v0.71` on Windows
### Added
- Integration with Azure Pipelines
## Updated
- New config lookup
- Upgraded babel, flow, eslint, and all other dependencies to latest semver 🎉🎉🎉 (This may introduce breaking changes)

## v3.6.0
## Updated
- Bumped all deps to latest semver
58 changes: 58 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
eslint-plugin-flowtype-errors
=============================

[![Build Status](https://dev.azure.com/amilajack/amilajack/_apis/build/status/amilajack.eslint-plugin-flowtype-errors?branchName=master)](https://dev.azure.com/amilajack/amilajack/_build/latest?definitionId=1&branchName=master)
[![NPM version](https://badge.fury.io/js/eslint-plugin-flowtype-errors.svg)](http://badge.fury.io/js/eslint-plugin-flowtype-errors)
[![Dependency Status](https://img.shields.io/david/amilajack/eslint-plugin-flowtype-errors.svg)](https://david-dm.org/amilajack/eslint-plugin-flowtype-errors)
[![npm](https://img.shields.io/npm/dm/eslint-plugin-flowtype-errors.svg)](https://npm-stat.com/charts.html?package=eslint-plugin-flowtype-errors)

## Demo

![ESLint Flow Demo](https://github.com/amilajack/eslint-plugin-flowtype-errors/blob/master/flow-demo.gif?raw=true)

## Why?

* **Lower barrier:** Any editor that has ESLint support now supports Flow 🎉
* **Less editor configuration:** No need to change your entire workflow to incorporate flow. No multiple-linters-per-file nonsense.
* **Simple:** Its literally just an ESLint rule! Just install the dependency, add a flowconfig, and you're good to go!

## Getting Started

This guide assumes that you have installed eslint, babel, babel-plugin-transform-flow-strip-types and configured flow. Check out the [from-scratch guide](https://github.com/amilajack/eslint-plugin-flowtype-errors/wiki/Getting-Started) for the full guide on getting started.

⚠️ Make sure the 64-bit version of your text editor or IDE. For atom, [see this comment](https://github.com/amilajack/eslint-plugin-flowtype-errors/issues/40#issuecomment-275983387)

### **1. Install**

```bash
npm install --save-dev eslint-plugin-flowtype-errors
```

### **2. Configure**

Extend the recommended config:
```jsonc
{
"extends": ["plugin:flowtype-errors/recommended"]
}
```

## Support

If this project is saving you (or your team) time, please consider supporting it on Patreon 👍 thank you!

<p>
<a href="https://www.patreon.com/amilajack">
<img src="https://c5.patreon.com/external/logo/become_a_patron_button@2x.png" width="160">
</a>
</p>

## CI Configuration

Flow is supported on all OS's except Windows 32bit. Add [this line](https://github.com/amilajack/eslint-plugin-flowtype-errors/blob/master/appveyor.yml#L12) to appveyor to make tests run properly.

## Related:

* [flow-runtime](https://github.com/codemix/flow-runtime)
* [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype)
* [eslint-plugin-flowtype-errors-demo](https://github.com/amilajack/eslint-plugin-flowtype-errors-demo)
31 changes: 0 additions & 31 deletions appveyor.yml

This file was deleted.

19 changes: 19 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
strategy:
matrix:
linux:
imageName: 'ubuntu-16.04'
mac:
imageName: 'macos-10.13'
windows:
imageName: 'vs2017-win2016'

pool:
vmImage: $(imageName)

steps:
- task: NodeTool@0
inputs:
versionSpec: '10.x'

- script: |
yarn && yarn test
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/* eslint-disable */
module.exports = require('./dist/index');
module.exports = require('./dist/index').default;
137 changes: 97 additions & 40 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
{
"name": "eslint-plugin-flowtype-errors",
"version": "3.6.0",
"version": "4.1.0",
"description": "Retrieve Flow errors as ESLint errors.",
"author": "Amila Welihinda",
"bugs": {
"url": "https://github.com/amilajack/eslint-plugin-flowtype-errors/issues"
},
"bugs": "https://github.com/amilajack/eslint-plugin-flowtype-errors/issues",
"homepage": "https://github.com/amilajack/eslint-plugin-flowtype-errors#readme",
"main": "index.js",
"scripts": {
"flow": "flow",
"build": "cross-env NODE_ENV=production babel src --out-dir dist",
"lint": "eslint --cache --format=node_modules/eslint-formatter-pretty .",
"prettier": "prettier --single-quote --write \"./src/*.js\"",
"preversion": "npm run build",
"spec": "npm run build && jest test/format.spec.js",
"spec-win": "npm run build && jest",
"test": "flow && npm run lint && npm run spec"
},
"repository": {
"type": "git",
"url": "git+https://github.com/amilajack/eslint-plugin-flowtype-errors.git"
"preversion": "yarn build",
"spec": "yarn build && jest",
"test": "yarn flow && yarn lint && yarn spec"
},
"repository": "https://github.com/amilajack/eslint-plugin-flowtype-errors",
"jest": {
"testEnvironment": "node"
},
@@ -36,44 +30,107 @@
"dist"
],
"dependencies": {
"babel-runtime": "^6.26.0",
"@babel/runtime": "^7.4.2",
"find-up": "^3.0.0",
"slash": "^2.0.0"
},
"devDependencies": {
"babel-cli": "^6.26.0",
"babel-eslint": "^8.2.3",
"babel-jest": "^23.0.0",
"babel-plugin-add-module-exports": "^0.2.1",
"babel-plugin-transform-flow-strip-types": "^6.22.0",
"babel-plugin-transform-runtime": "^6.23.0",
"babel-preset-env": "^1.7.0",
"babel-preset-flow": "^6.23.0",
"babel-preset-stage-0": "^6.24.1",
"babel-register": "^6.26.0",
"chai": "^4.1.2",
"cross-env": "^5.1.6",
"@babel/cli": "^7.2.3",
"@babel/core": "^7.4.0",
"@babel/plugin-proposal-class-properties": "^7.4.0",
"@babel/preset-env": "^7.4.2",
"@babel/preset-flow": "^7.0.0",
"@babel/register": "^7.4.0",
"babel-core": "^7.0.0-bridge.0",
"babel-eslint": "^10.0.1",
"babel-jest": "^24.5.0",
"chai": "^4.2.0",
"cross-env": "^5.2.0",
"cross-spawn": "^6.0.5",
"eslint": "4.19.1",
"eslint-config-airbnb-base": "^12.1.0",
"eslint-config-prettier": "^2.9.0",
"eslint-formatter-pretty": "^1.3.0",
"eslint-nibble-ignore": "^3.0.0",
"eslint-plugin-flowtype": "^2.47.1",
"eslint-plugin-html": "^4.0.3",
"eslint-plugin-import": "^2.12.0",
"eslint-plugin-prettier": "^2.6.0",
"eslint-plugin-vue": "^4.5.0",
"flow-bin": "^0.73.0",
"jest-cli": "^23.0.0",
"prettier": "^1.12.1",
"regenerator-runtime": "^0.11.1"
"eslint": "5.15.3",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-config-prettier": "^4.1.0",
"eslint-formatter-pretty": "^2.1.1",
"eslint-plugin-flowtype": "^3.4.2",
"eslint-plugin-html": "^5.0.3",
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-prettier": "^3.0.1",
"eslint-plugin-vue": "^5.2.2",
"execa": "^1.0.0",
"flow-bin": "0.95.1",
"husky": "^1.3.1",
"jest-cli": "^24.5.0",
"prettier": "^1.16.4",
"regenerator-runtime": "^0.13.2"
},
"peerDependencies": {
"eslint": ">=4.0.0",
"flow-bin": ">=0.69.0"
"flow-bin": ">=0.93.0"
},
"engines": {
"node": ">=4.x",
"npm": ">=5.x"
},
"babel": {
"presets": [
[
"@babel/preset-env",
{
"targets": {
"node": 10
},
"useBuiltIns": "usage"
}
],
"@babel/preset-flow"
]
},
"eslintConfig": {
"extends": [
"airbnb-base",
"prettier",
"prettier/flowtype"
],
"parser": "babel-eslint",
"env": {
"node": true,
"es6": true
},
"plugins": [
"flowtype",
"prettier"
],
"rules": {
"consistent-return": "off",
"flowtype/define-flow-type": "error",
"fp/no-arguments": "off",
"fp/no-class": "off",
"fp/no-delete": "off",
"fp/no-events": "off",
"fp/no-get-set": "off",
"fp/no-let": "off",
"fp/no-loops": "off",
"fp/no-mutating-assign": "off",
"fp/no-mutating-methods": "off",
"fp/no-mutation": "off",
"fp/no-nil": "off",
"fp/no-proxy": "off",
"fp/no-rest-parameters": "off",
"fp/no-this": "off",
"fp/no-throw": "off",
"fp/no-unused-expression": "off",
"fp/no-valueof-field": "off",
"prefer-destructuring": "off"
}
},
"renovate": {
"extends": [
"bliss"
]
},
"husky": {
"hooks": {
"pre-commit": "yarn test"
}
}
}
Loading