Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate replicas in statefulset #92

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

donbowman
Copy link
Contributor

The duplicate key in yaml breaks kustomize.

@donbowman donbowman requested a review from tazarov as a code owner January 18, 2025 23:00
@donbowman donbowman force-pushed the remove-duplicate-replicas branch from 99ebd72 to 7aa6669 Compare January 18, 2025 23:00
@donbowman donbowman force-pushed the remove-duplicate-replicas branch from 7aa6669 to 144010c Compare January 18, 2025 23:01
@tazarov
Copy link
Contributor

tazarov commented Jan 19, 2025

@donbowman, thanks for this. I think the root cause is a merge conflict that ended up with this weird duplication of things.

Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@tazarov tazarov merged commit 7141f11 into amikos-tech:main Jan 19, 2025
7 checks passed
@donbowman donbowman deleted the remove-duplicate-replicas branch January 19, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants