Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(intl): import from crypto for better backward compatibility #61

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

10xLaCroixDrinker
Copy link
Member

Description

import createHash from crypto instead of node:crypto

Motivation and Context

This the same package, but the import change will fix users whose unit tests broke when on older versions of Jest.

How Has This Been Tested?

  1. Installed Jest 24 and ran tests to reproduce the error
  2. Made the change & saw error resolved
  3. Switched back to Jest 29 and ran unit tests (passed)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for one-app-ducks users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using one-app-ducks?

Users whose Jest tests failed after updating one-app-ducks will be able to run the Jest tests again

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 7106d8d into main Oct 5, 2022
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/crypto-import branch October 5, 2022 20:39
oneamexbot added a commit that referenced this pull request Oct 5, 2022
## [4.4.1](v4.4.0...v4.4.1) (2022-10-05)

### Bug Fixes

* **intl:** import from crypto for better backward compatibility ([#61](#61)) ([7106d8d](7106d8d))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 4.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants