This repository has been archived by the owner on May 15, 2024. It is now read-only.
fix(intl): support wildcard for Accept-Language header #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the
activeLocale
to the default locale when a wildcard is passed for Accept-Language.Motivation and Context
If the
Accept-Language
header on a request is set to"*"
, the value of theactiveLocale
in state will also be set to"*"
, which is not generally going to be a valid locale value by consumers.For instance, if passed to react-intl, the following error occurs:
Using a wildcard for Accept-Language is not common but it is in the spec: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Language
Fixes #30.
How Has This Been Tested?
Fix was straightforward so primary testing was in unit tests.
Types of Changes
Checklist:
What is the Impact to Developers Using one-app-ducks?
If someone was dependent on the
activeLocale
being set to "*", their code may stop working properly.