This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat(rendering): add setTextOnly duck #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomcal
previously approved these changes
Sep 8, 2020
nellyk
reviewed
Sep 8, 2020
JAdshead
reviewed
Sep 8, 2020
README.md
Outdated
| | Argument | Type | Description | | ||
| |---|---|---| | ||
| | `setTextOnly` | `Boolean` | (required) set whether to return text instead of HTML | | ||
| | `tagReplacement` | `String` | Replace html tags with the character passed to this option i.e. '/n'. Defaults to empty string. | |
There was a problem hiding this comment.
so there can only be one replacement, not possible to have <p> replaced with empty string and <h1> replaced with /n ?
There was a problem hiding this comment.
Yeah that's the limitation of that strip tags library replace all of them or nothing
There was a problem hiding this comment.
also looks like it has not been maintained in the last 3 years
There was a problem hiding this comment.
I saw that, not sure if it should change much... what I like about it is doesn't use regex. We need to balance this drawback compared to creating and maintaining a new library ourselves
10xLaCroixDrinker
suggested changes
Sep 10, 2020
Co-authored-by: Jimmy King <jimmy.king@aexp.com>
13 tasks
10xLaCroixDrinker
approved these changes
Sep 22, 2020
JAdshead
approved these changes
Sep 22, 2020
mtomcal
approved these changes
Sep 22, 2020
oneamexbot
added a commit
that referenced
this pull request
Sep 23, 2020
# [4.2.0](v4.1.1...v4.2.0) (2020-09-23) ### Features * **rendering:** add setTextOnly duck ([#17](#17)) ([a18a2df](a18a2df))
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rendering duck to add module as a text functionality.