fix(eslint): disable prevent abbreviations #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
previously approved these changes
May 11, 2020
JamesSingleton
previously approved these changes
May 11, 2020
|
This should probably be of type |
Francois-Esquire
previously approved these changes
May 11, 2020
Technically, it is. You get an error when you |
10xLaCroixDrinker
previously approved these changes
May 11, 2020
PixnBits
previously requested changes
May 12, 2020
stevensacks
dismissed stale reviews from 10xLaCroixDrinker, Francois-Esquire, JamesSingleton, and JAdshead
via
55c2e7c
10xLaCroixDrinker
previously approved these changes
May 29, 2020
|
@stevensacks you just need to resolve the conflicts here. |
10xLaCroixDrinker
previously approved these changes
Jun 5, 2020
JamesSingleton
previously approved these changes
Jun 5, 2020
|
@PixnBits I made the change you requested. Conflicts resolved. |
JAdshead
dismissed stale reviews from JamesSingleton and 10xLaCroixDrinker
via
45135eb
JamesSingleton
approved these changes
Jun 30, 2020
JAdshead
approved these changes
Jun 30, 2020
10xLaCroixDrinker
approved these changes
Jun 30, 2020
JAdshead
pushed a commit
that referenced
this pull request
Jul 16, 2020
oneamexbot
added a commit
that referenced
this pull request
Jul 16, 2020
# [13.0.0](v12.2.0...v13.0.0) (2020-07-16) ### Bug Fixes * **eslint:** disable prevent abbreviations ([#33](#33)) ([6647bef](6647bef)) ### Features * **eslint:** configuration ([#30](#30)) ([6229d4a](6229d4a)) * **eslint:** disable function scoping ([#35](#35)) ([0a0c5bb](0a0c5bb)) * **eslint:** disable prefer default export ([#26](#26)) ([45b88d3](45b88d3)) * **eslint:** enable jest rules ([#29](#29)) ([846bbf7](846bbf7)) * **eslint:** react/jsx quality of life rules ([#24](#24)) ([facff92](facff92)) * **js:** additional js rules ([58df834](58df834)) * **prettier:** add ([#45](#45)) ([00cecaf](00cecaf)) * **unicorn:** update and seperate rules ([#43](#43)) ([940eb66](940eb66)) * **unicorn/consistent-function-scoping:** disable ([#42](#42)) ([54dd5a3](54dd5a3)) ### BREAKING CHANGES * **unicorn:** major update to unicorn * **js:** no-lonely-if errors * **js:** no-return-assign, errors * **js:** prefer-object-spread, errors * **js:** no-bitwise, errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing abbreviations is incompatible with React standards (props, ref, etc.). Additionally, there are many scenarios where abbreviations are acceptable.
In the future, we may decide to make a whitelist, but since that will take time to decide and this rule is currently in the published ruleset, we are releasing it with the rule disabled for now to address this problem quickly.