Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update dependencies to latest version #16

Merged
merged 1 commit into from
Mar 30, 2020
Merged

feat(deps): update dependencies to latest version #16

merged 1 commit into from
Mar 30, 2020

Conversation

JamesSingleton
Copy link
Contributor

@JamesSingleton JamesSingleton commented Mar 26, 2020

BREAKING CHANGE: Updates deps major versions

So the reason why typescript was due to the latest version of eslint-plugin-jest which has a dependency on @typescript-eslint/experimental-utils which has a dependency on @typescript-eslint/typescript-estree which has a dependency on tsutils which apparently requires typescript.

Furthermore, this now fixes optional chaining which was throwing a linting error due to babel-eslint being a v7 instead of v10

Changes for babel-eslint

From 7 to 8:

  • No major changes, just updating babel deps to v7

From 8 to 9:

  • Babel removed the support for Node 4 , so I propagated that here.
  • supports the new decorators proposal by default

From 9 to 10:

  • Drop monkeypatching behavior
  • add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code)

Changes for eslint-plugin-unicorn

This goes from v5.0.0 to v18.0.0 so there are a lot of changes. So I am going to add the ones in their changelog that are deemed breaking.

v16

  • Requires Node 10

v13

  • Change some options for prevent-abbreviations rule

v10

  • Require ESLint 6

v9

  • Require Node.js 8
  • Use underscore naming pattern in the catch-error-name rule

BREAKING CHANGE: Updates deps major versions
@JamesSingleton JamesSingleton requested a review from a team as a code owner March 26, 2020 22:04
Copy link
Member

@anescobar1991 anescobar1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add BREAKING CHANGE in the commit message. This repo uses semantic release.

@JamesSingleton JamesSingleton merged commit 27ad145 into americanexpress:master Mar 30, 2020
oneamexbot added a commit that referenced this pull request Mar 30, 2020
# [12.0.0](v11.2.0...v12.0.0) (2020-03-30)

### Features

* **deps:** update dependencies to latest version ([#16](#16)) ([27ad145](27ad145))

### BREAKING CHANGES

* **deps:** Updates deps major versions
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants