Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The property "INCLUDE_DIRECTORIES" is not allowed. #120

Closed
Karsten1987 opened this issue Jan 10, 2019 · 0 comments
Closed

The property "INCLUDE_DIRECTORIES" is not allowed. #120

Karsten1987 opened this issue Jan 10, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Karsten1987
Copy link
Contributor

When trying to compile rosbag2 with the latest ros2 master, I run into the following cmake error. I believe it's related to #117

Do we have to change something in the rosbag2 code base?

--- stderr: rosbag2_test_common
CMake Error at /root/ros2_ws/install/share/ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake:36 (get_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "INCLUDE_DIRECTORIES" is not allowed.
Call Stack (most recent call first):
  /root/ros2_ws/install/share/ament_cmake_core/cmake/core/ament_execute_extensions.cmake:38 (include)
  /root/ros2_ws/install/share/ament_lint_auto/cmake/ament_lint_auto_package_hook.cmake:15 (ament_execute_extensions)
  /root/ros2_ws/install/share/ament_cmake_core/cmake/core/ament_execute_extensions.cmake:38 (include)
  /root/ros2_ws/install/share/ament_cmake_core/cmake/core/ament_package.cmake:66 (ament_execute_extensions)
  CMakeLists.txt:43 (ament_package)

The rosbag2 code in question is relatively simple:
https://github.com/ros2/rosbag2/blob/master/rosbag2_test_common/CMakeLists.txt#L20-L41

  target_include_directories(${PROJECT_NAME} INTERFACE
    $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
    $<INSTALL_INTERFACE:include>)

When resetting ament_cmake_cppcheck to version 0.6.2 it compiles correctly.

@dirk-thomas dirk-thomas added the bug Something isn't working label Jan 10, 2019
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Jan 11, 2019
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jan 11, 2019
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants