Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenMM 8.1 #12

Open
DanielWicz opened this issue Jan 8, 2024 · 10 comments · May be fixed by #14
Open

Support for OpenMM 8.1 #12

DanielWicz opened this issue Jan 8, 2024 · 10 comments · May be fixed by #14

Comments

@DanielWicz
Copy link

Is the support for OpenMM 8.1 planned ?

@ex-rzr
Copy link
Contributor

ex-rzr commented Jan 9, 2024

The changes required for 8.1 are ported, it would be great to have more test results before merging them. See #11

@DanielWicz
Copy link
Author

I can test it on MI250. The only problem is that I can't compile it on the host server, so I need some beta conda package or something like this.

@ex-rzr
Copy link
Contributor

ex-rzr commented Jan 10, 2024

What it ROCm version there?

@DanielWicz
Copy link
Author

What it ROCm version there?

5.5.1

@DanielWicz
Copy link
Author

Update, I just got access to 5.7.1 and 6.0.0

@ex-rzr
Copy link
Contributor

ex-rzr commented Jan 18, 2024

Great! I can't promise but I'll try to find time this weekend to create the conda package (and I also need to test on 6.0)

@DanielWicz
Copy link
Author

DanielWicz commented Jan 18, 2024

Great! I can't promise but I'll try to find time this weekend to create the conda package (and I also need to test on 6.0)

Thanks! I tried to use the old versiom for 8.0 with 6.0.0, but it gives error:

openmm.OpenMMException: Error launching HIP compiler: 256
clang: error: cannot find HIP runtime; provide its path via '--rocm-path', or pass '-nogpuinc' to build without HIP runtime

But I guess the old version is not prepared for the 6.0.0. There was a change of compiler directory in the 6.0.0

Edit: 5.7.1 gives in fact the same error. The ROCM_PATH is set and valid in both cases.

@ex-rzr
Copy link
Contributor

ex-rzr commented Jan 18, 2024

That's really strange, I think 5.7 should work (the error has nothing to do with binary compatibility which I would expect).

Can you check with export OPENMM_USE_HIPRTC=1? See https://github.com/amd/openmm-hip#the-kernel-compilation-hipcc-and-hiprtc
Perhaps, now it's time to make hipRTC enabled by default (or even the only way to compile), but this requires benchmarking as previously hipRTC generated slower code than the standalone compiler. Likely it has changed in recent version of ROCm.

@ex-rzr ex-rzr linked a pull request Jan 21, 2024 that will close this issue
@ex-rzr
Copy link
Contributor

ex-rzr commented Jan 21, 2024

Please check #14, I've prepared a beta package built on ROCm 6.0.0.

@DanielWicz
Copy link
Author

export OPENMM_USE_HIPRTC=1

I checked with "export OPENMM_USE_HIPRTC=1" and it makes it work. There is a performance drop of 1-2% for my system, for the version 5.7.1.

Please check #14, I've prepared a beta package built on ROCm 6.0.0.

Thank! I will check this week and give a feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants