desktopvirtualization\hostpool

Added registration_token attribute to top level hostpool so we can setnewcomputed when registration_info changes

Author: Andy.McCullough

internal/services/desktopvirtualization/virtual_desktop_host_pool_resource.go

@@ -1,6 +1,7 @@
 package desktopvirtualization
 
 import (
+	"context"
 	"fmt"
 	"log"
 	"time"
@@ -43,6 +44,8 @@ func resourceVirtualDesktopHostPool() *pluginsdk.Resource {
 			0: migration.HostPoolV0ToV1{},
 		}),
 
+		CustomizeDiff: pluginsdk.CustomizeDiffShim(hostpoolRegistrationCustomDiff),
+
 		Schema: map[string]*pluginsdk.Schema{
 			"name": {
 				Type:         pluginsdk.TypeString,
@@ -160,12 +163,28 @@ func resourceVirtualDesktopHostPool() *pluginsdk.Resource {
 					},
 				},
 			},
+			//Added new
+			"registration_token": {
+				Type:      pluginsdk.TypeString,
+				Sensitive: true,
+				Computed:  true,
+			},
 
 			"tags": tags.Schema(),
 		},
 	}
 }
 
+func hostpoolRegistrationCustomDiff(ctx context.Context, d *pluginsdk.ResourceDiff, _ interface{}) error {
+	if d.HasChange("registration_info") {
+		if err := d.SetNewComputed("registration_token"); err != nil {
+			return err
+		}
+		return nil
+	}
+	return nil
+}
+
 func resourceVirtualDesktopHostPoolCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
 	client := meta.(*clients.Client).DesktopVirtualization.HostPoolsClient
 	subscriptionId := meta.(*clients.Client).Account.SubscriptionId
@@ -268,6 +287,9 @@ func resourceVirtualDesktopHostPoolRead(d *pluginsdk.ResourceData, meta interfac
 		if err := d.Set("registration_info", flattenVirtualDesktopHostPoolRegistrationInfo(props.RegistrationInfo)); err != nil {
 			return fmt.Errorf("setting `registration_info`: %+v", err)
 		}
+		if regInfo := props.RegistrationInfo; regInfo != nil {
+			d.Set("registration_token", regInfo.Token)
+		}
 	}
 
 	return tags.FlattenAndSet(d, resp.Tags)

internal/services/desktopvirtualization/virtual_desktop_host_pool_resource_test.go

@@ -125,6 +125,16 @@ resource "azurerm_virtual_desktop_host_pool" "test" {
   type                 = "Pooled"
   validate_environment = true
   load_balancer_type   = "BreadthFirst"
+
+  # Do not use timestamp() outside of testing due to https://github.com/hashicorp/terraform/issues/22461
+  registration_info {
+    expiration_date = timeadd(timestamp(), "48h")
+  }
+  lifecycle {
+    ignore_changes = [
+      registration_info[0].expiration_date,
+    ]
+  }
 }
 `, data.RandomInteger, data.Locations.Secondary, data.RandomString)
 }