Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPZ-1: Code fixes and review #4

Open
17 tasks done
ambrose40 opened this issue Oct 14, 2020 · 1 comment · May be fixed by #12
Open
17 tasks done

WPZ-1: Code fixes and review #4

ambrose40 opened this issue Oct 14, 2020 · 1 comment · May be fixed by #12
Assignees
Labels
improvement Code review, improvements, good practices
Milestone

Comments

@ambrose40
Copy link
Owner

ambrose40 commented Oct 14, 2020

Estimated time: 1 hour

  • Starting from the master branch, create a new branch chore/code-review.
  • Create a file named CODE_REVIEW.md at the workspace root write a short code review based on the existing code.
  • Are there any problems or code smells in the app? (Focus on code in the libs/books folder)
  • Are there other improvements you would make to the app? What are they and why?
  • Good practices
  • Write your review in bullet points. You should list at least three items.
  • Google Chrome, run an automated scan with the Lighthouse extension. Lighthouse, note these issues.
  • Chrome again, manually check for accessibility issues.
  • Identify at least 3 issue, not found in the automated scan.
  • Fix at least one of the issues noted in step 2 and all the issues from step 3.
  • Run lint
  • Run unit tests
  • Run e2e tests.
  • Fix anything that fails.
  • Commit your changes to the feature branch.
  • Open a pull-request with master as the target.
  • You should now have two commits on master.
@ambrose40 ambrose40 added the improvement Code review, improvements, good practices label Oct 14, 2020
@ambrose40 ambrose40 self-assigned this Oct 14, 2020
@ambrose40 ambrose40 linked a pull request Oct 14, 2020 that will close this issue
19 tasks
@ambrose40 ambrose40 added this to the 15.10.2020 milestone Oct 15, 2020
@ambrose40 ambrose40 pinned this issue Oct 15, 2020
@ambrose40 ambrose40 unpinned this issue Oct 15, 2020
@ambrose40 ambrose40 mentioned this issue Oct 15, 2020
10 tasks
@ambrose40 ambrose40 linked a pull request Oct 16, 2020 that will close this issue
16 tasks
@ambrose40 ambrose40 removed a link to a pull request Oct 16, 2020
19 tasks
@ambrose40
Copy link
Owner Author

Done.

@ambrose40 ambrose40 reopened this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Code review, improvements, good practices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant