Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make GPhase more efficient #245

Merged
merged 4 commits into from
Apr 12, 2024
Merged

fix: Make GPhase more efficient #245

merged 4 commits into from
Apr 12, 2024

Conversation

speller26
Copy link
Member

GPhase applies to no qubits rather than all qubits when no targets are supplied.

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

`GPhase` applies to no qubits rather than all qubits when no targets are supplied.
@speller26 speller26 requested a review from shpface April 12, 2024 22:47
@speller26 speller26 requested a review from a team as a code owner April 12, 2024 22:47
@speller26 speller26 linked an issue Apr 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1187ce9) to head (59f6f4c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         3781      3779    -2     
  Branches       917       916    -1     
=========================================
- Hits          3781      3779    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shpface
shpface previously approved these changes Apr 12, 2024
@speller26 speller26 merged commit 46f03f5 into main Apr 12, 2024
33 checks passed
@speller26 speller26 deleted the gphase branch April 12, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using rz results in process being killed (OOM?)
2 participants