Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Braket Direct reservations #80

Closed
kshyatt-aws opened this issue May 8, 2024 · 2 comments · Fixed by #87
Closed

Support for Braket Direct reservations #80

kshyatt-aws opened this issue May 8, 2024 · 2 comments · Fixed by #87
Assignees
Labels
good first issue Good for newcomers

Comments

@kshyatt-aws
Copy link
Contributor

Describe the feature you'd like
Amazon Braket now has the Braket Direct feature, which allows users to reserve certain Direct-only devices or access experimental capabilities of devices.

Is this feature already present in the Python SDK?
Yes. https://github.com/amazon-braket/amazon-braket-sdk-python/blob/main/src/braket/aws/direct_reservations.py

How would this feature be used? Please describe.
This allows users to provide a reservation arn to access their reservation, as in the BDK.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@kshyatt-aws kshyatt-aws added the good first issue Good for newcomers label May 14, 2024
@Fe-r-oz
Copy link

Fe-r-oz commented Jun 7, 2024

This seem interesting! We need to define DirectReservations in aws/Device.jl . We have AwsDevice, Device here but I am not sure about AbstractContextManager. It seems to be imported from

from contextlib import AbstractContextManager

But I am not sure what's the equivalent of AbstractContextManager here. Please let me know! Thanks

There is a lot of Mock Tests about DirectReservations in test_direct_reservations.py

@Fe-r-oz
Copy link

Fe-r-oz commented Jun 7, 2024

But I am not sure what's the equivalent of AbstractContextManager here.

It seems that we can use "do notation" in place for AbstractContextManager!

https://groups.google.com/g/julia-users/c/leNMURKreZo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants