Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supersaturated water #192

Open
ecoon opened this issue May 30, 2023 · 2 comments
Open

Supersaturated water #192

ecoon opened this issue May 30, 2023 · 2 comments
Labels
reactive-transport-roundup Low-hanging fruit for quick fixups in ATS Integrated Reactive Transport

Comments

@ecoon
Copy link
Collaborator

ecoon commented May 30, 2023

In transport, sinks of water (evaporation, freezing) can result in increasing concentration without bound, but this can break geochemical engines. In the real world, such water becomes supersaturated and precipitates solids. Transport already has a pool of solid_residue that is meant to store this solid when water disappears completely. It should be easy to

  1. Allow the user to provide a max concentration, by specie, default = inf,
  2. In transport, if C reaches this value, precipitate out into solid residue sufficient C to reach C_max.
@ecoon ecoon added the reactive-transport-roundup Low-hanging fruit for quick fixups in ATS Integrated Reactive Transport label May 30, 2023
@hiter-joe
Copy link

Hi Ethan,

I've updated the code and thoroughly tested the maximum concentration for different components.
Everything seems to be working well from my end.
I was eager to create a pull request, but unfortunately, I encountered an issue.
It appears that I'm not a collaborator on the ATS GitHub repository.

I would greatly appreciate any suggestions or guidance you may have on how to proceed with creating that pull request.
Thanks,
Bing

@ecoon
Copy link
Collaborator Author

ecoon commented Jul 27, 2023

@hiter-joe You should be good now Bing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reactive-transport-roundup Low-hanging fruit for quick fixups in ATS Integrated Reactive Transport
Projects
None yet
Development

No branches or pull requests

2 participants