Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add evaluators for interpolation in time, use them in ats transport #186

Open
ecoon opened this issue Mar 16, 2023 · 1 comment
Open

add evaluators for interpolation in time, use them in ats transport #186

ecoon opened this issue Mar 16, 2023 · 1 comment
Assignees

Comments

@ecoon
Copy link
Collaborator

ecoon commented Mar 16, 2023

There is a lot of weird code in ATS transport based on the need for transport to manually interpolate between an "old saturation/density" and a "new saturation/density" onto a subcycled old and new value.

This would all go away and be much cleaner if these were evaluators. To do this we need:

  1. a time interpolating evaluator
  2. refactor the transport pk to use sat/dens at the right tag instead of hard-coding in "flow tags"
@ecoon ecoon self-assigned this Mar 16, 2023
@ecoon
Copy link
Collaborator Author

ecoon commented Aug 27, 2024

Note the current use of tags (or non-use) in transport means that transport subcycling is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant