feat: Business Trip #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
General Feedback
Connection to Expense Claim
Problem: Custom field "business_trip" is missing in Expense Claim. Also HRMS is no dependency yet of this app.
Solutions:
- Solve the problems.
- Delete connection to Expense Claim and respective parts of the on_submit method
Add Patch
IMO Business Trip Region can be inserted via patch.
PatrickDEissler
approved these changes
Oct 1, 2024
barredterra
pushed a commit
that referenced
this pull request
Oct 1, 2024
# [15.5.0](v15.4.2...v15.5.0) (2024-10-01) ### Features * Business Trip ([#43](#43)) ([e9d28bc](e9d28bc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal reference: DRC-13