fix: check for latest transaction of the same company only #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
reviewed
Jul 24, 2024
|
General thought: shouldn't this be per naming series instead of per company? In theory, two companies could use the same naming series and then this code would permit gaps. But I guess it's okay to assume that his won't happen. |
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
I thought about this for a while too, but I can't think of a scenario where this would make sense. I guess it could be easily added if someone really needs this. |
barredterra
approved these changes
Jul 24, 2024
barredterra
changed the title
|
@Mergifyio backport version-14 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> (cherry picked from commit e62962d)
barredterra
pushed a commit
that referenced
this pull request
Jul 24, 2024
## [15.3.3](v15.3.2...v15.3.3) (2024-07-24) ### Bug Fixes * check for latest transaction of the same company only ([#38](#38)) ([e62962d](e62962d))
barredterra
added a commit
that referenced
this pull request
Jul 24, 2024
) (#40) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Co-authored-by: Markus Lobedann <markus.lobedann@gmail.com>
|
Thank you very much, that was fast :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37
please also backport to version-14