Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'whats left to scan' reporting a blank list when entering system #64

Open
SiIason opened this issue Aug 16, 2020 · 5 comments
Open

'whats left to scan' reporting a blank list when entering system #64

SiIason opened this issue Aug 16, 2020 · 5 comments

Comments

@SiIason
Copy link

SiIason commented Aug 16, 2020

Happening when one a single star in the system,
Have since noticed it once when 2 stars were in close.

@SiIason SiIason changed the title 'whats left to scan' reporting a blank list 'whats left to scan' reporting a blank list when entering system Aug 16, 2020
@alterNERDtive alterNERDtive added EliteAttack enhancement New feature or request EDDI done implemented, but not merged into release yet bug Something isn't working and removed enhancement New feature or request done implemented, but not merged into release yet labels Aug 17, 2020
@alterNERDtive
Copy link
Owner

alterNERDtive commented Aug 17, 2020

Have since noticed it once when 2 stars were in close.

Ah, good. I was worried I hadn’t understood what happened there. For the record, close or not doesn’t matter for stars. The trigger here is a race condition when you finish scanning the entire system (that triggers this) too fast after entering a system. That can happen when you don’t have anything left to scan after honking because there are either only stars or only stars and bodies that are within honking distance (50 ls).

NB: that should also be able to happen when you have the “announce R2R mapping candidates” option enabled since that triggers this after honking, no matter the system scan state. Moving it from the Discovery scan to the Jumped event (see #61) might will make it worse for that case.

Bottom line is still: this looks like an EDDI issue to me. I suspect that it’s not done getting system data from EDSM yet when this happens, and the bodies to map speech responder script doesn’t handle that gracefully.

@alterNERDtive
Copy link
Owner

So current EDDI beta lists this change:

Bodies to map updated to default to the current star system if context variable eddi_context_system_name is not set and updated the P() function utilization.

I suspect this bug here might be the result of a race condition that existed before, when the new system name had not been set. So the beta might fix this.

@alterNERDtive
Copy link
Owner

@SiIason have you run into this since? I haven’t, but I haven’t really been looking out for it.

@alterNERDtive alterNERDtive unpinned this issue Jun 23, 2021
@alterNERDtive
Copy link
Owner

Just ran into this, so it’s definitely still a thing :-/

@alterNERDtive alterNERDtive added this to the 5.0 milestone Feb 4, 2022
@alterNERDtive
Copy link
Owner

Anyone still seeing this? I’m not really playing anymore so couldn’t tell.

@alterNERDtive alterNERDtive removed this from the 5.0 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants