Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in event handlers exit silently #125

Closed
9ary opened this issue Aug 29, 2019 · 2 comments
Closed

Exceptions in event handlers exit silently #125

9ary opened this issue Aug 29, 2019 · 2 comments
Assignees
Labels

Comments

@9ary
Copy link

9ary commented Aug 29, 2019

Minimal working example:

import i3ipc

def on_window(self, e):
    raise Exception

conn = i3ipc.Connection()
conn.on('window', on_window)
conn.main()

This will just exit silently without printing a backtrace, and return code 0. Seems to happen on both 1.7.1 and 2.0.1.

@9ary 9ary added the bug label Aug 29, 2019
@acrisci
Copy link
Member

acrisci commented Aug 29, 2019

Yeah this isn't good. The i3ipc.aio.Connection will raise the exception from the main loop. I should probably just have that behavior for the normal Connection as well.

@acrisci acrisci closed this as completed in 727cff8 Sep 2, 2019
@9ary
Copy link
Author

9ary commented Sep 2, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants