Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arXiv favicon #1704

Closed
ninyam opened this issue Sep 5, 2023 · 7 comments
Closed

New arXiv favicon #1704

ninyam opened this issue Sep 5, 2023 · 7 comments

Comments

@ninyam
Copy link

ninyam commented Sep 5, 2023

Hi there!

This is not really an issue.
I want my site to display the new arXiv favicon [https://jpswalsh.github.io/academicons/].

But I don't know how to modify the settings to make this possible.

Thanks a lot for your help!

@george-gca
Copy link
Collaborator

If the icon is already showing somewhere, but it is just not the updated one, all you need to do is update the version of academicon used in _config.yml

@ninyam
Copy link
Author

ninyam commented Sep 8, 2023

Thank you!
I just changed it the 1.9.1 to 1.9.4. However, it didn't work.
I had ORCID, Scopus and arXiv academicons showing with 1.9.1, but when I changed the version they disappeared.

Is this because I also need to change the integrity below version?

Thank you!

@george-gca
Copy link
Collaborator

Yes, you also have to update the integrity. The integrity is the hash of the file. With the wrong integrity the file will not load at all.

@global-anomaly
Copy link
Contributor

global-anomaly commented Sep 11, 2023

As you can see here, the latest academicons npm package is 1.9.2 and not the 1.9.4. So you will not be able to get an integrity for 1.9.4.

For 1.9.2 the integrity is "sha256-CylD++oS3IkJmSs/j4i1w0cv2wpVQRLLQqw/m+Fvxts=". I used the SRI Hash Generator

But, the new arXiv icon isn't there as well.

I have tested the 1.9.4 locally by manually installing.

  • Download the latest zip from here
  • extract and place the zip inside /assets/fonts/ as academicons
  • Replace line 13 of _includes/head.html with <link rel="stylesheet" href="assets/fonts/academicons/css/academicons.min.css"/>
  • now it works.

I don't know how much this will hamper the site speed. @george-gca Is it good to install the fonts locally or call from the cdn?

@george-gca
Copy link
Collaborator

Apparently it's been a while since the npm package was updated. Also there are still missing icons from academicons that could be added (I created a feature request for one a while ago). One day I will create a PR for this.

According to this site, it would be better to load things from CDN since it can load from sources closer to the user. At the same time, loading locally can offer other benefits when used with some other solutions like this one here. I will try to do some more thorough tests with the purgecss solution, then maybe include it with locally loaded academicons too.

@george-gca
Copy link
Collaborator

george-gca commented Sep 12, 2023

EDIT: I just realized that I did include academicons in the solution with purgecss already. I will try to find some time on the weekend to see this through.

I would for now recommend locally loading the academicons package if you want the latest version. If someone could send a PR for this would be great.

@alshedivat alshedivat linked a pull request Sep 17, 2023 that will close this issue
@george-gca
Copy link
Collaborator

I believe this was fixed in #1562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants