Package broken on Melpa

[adam52]

I did an Upgrade recently, of all my packages on Melpa. Now when I run helm-org-rifle I am prompted for a "PATTERN:" (which I key in) and I can then select a result in the indirect buffer.

However, when I hit [enter] to complete the selection, I receive an error message:

Wrong number of arguments: (1 . 1), 0

Any ideas?

Thanks,
-Adam

[adam52]

Thierry Volpiatto, who maintains the helm package, gave me this fix. In helm-org-rifle.el find this code:

  (helm-cleanup-hook (lambda ()
                       ;; Close new buffers if enabled
                       (when helm-org-rifle-close-unopened-file-buffers
                         (if (= 0 helm-exit-status)
                             ;; Candidate selected; close other new buffers
                             (let ((candidate-source (helm-attr 'name (helm-get-current-source))))
                               (dolist (source (helm-get-sources))
                                 (unless (or (equal (helm-attr 'name source)
                                                    candidate-source)
                                             (not (helm-attr 'new-buffer source)))
                                   (kill-buffer (helm-attr 'buffer source)))))
                           ;; No candidates; close all new buffers
                           (dolist (source (helm-get-sources))
                             (when (helm-attr 'new-buffer source)
                               (kill-buffer (helm-attr 'buffer source))))))))))

and replace both lines that say (dolist (source (helm-get-sources)) with (dolist (source helm-sources).

Here's the thread over on the helm page: issue 2007.

[alphapapa]

Thanks for reporting and finding the fix!

[adam52]

No worries. Thank you!

…

On 16 Apr 2018, at 19:47, alphapapa ***@***.***> wrote: Thanks for reporting and finding the fix! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABONSQjlYOJARbu5qT8MntQIZnGwpaNGks5tpOdYgaJpZM4S-4O3>.