From 6c600186fcef781b1a05ce07da41720317e91cbc Mon Sep 17 00:00:00 2001
From: Paul Hayes <fofr@users.noreply.github.com>
Date: Fri, 18 Nov 2016 10:17:12 +0000
Subject: [PATCH] Remove external link styles

After static was updated to latest toolkit, the external link image
disappeared, breaking the display of external links in apps.

* Remove use of mixins no longer provided by toolkit
* Remove white external link shim
* Remove white external link images

Original PR and discussion:
https://github.com/alphagov/govuk_frontend_toolkit/pull/293
---
 .../images/external-link-white-12x12.png      | Bin 233 -> 0 bytes
 .../images/external-link-white-24x24.png      | Bin 283 -> 0 bytes
 .../stylesheets/frontend/global/_links.scss   |   8 --------
 .../frontend/helpers/_attachment.scss         |   3 ---
 .../frontend/helpers/_featured-links.scss     |   7 -------
 .../frontend/helpers/_featured_news.scss      |   4 ----
 .../frontend/helpers/_metadata-list.scss      |   7 -------
 .../frontend/styleguide/_typography.scss      |  18 ------------------
 .../frontend/views/_html-publications.scss    |   4 ----
 .../frontend/views/_organisations.scss        |   3 ---
 .../frontend/views/_world_locations.scss      |   7 -------
 11 files changed, 61 deletions(-)
 delete mode 100644 app/assets/images/external-link-white-12x12.png
 delete mode 100644 app/assets/images/external-link-white-24x24.png

diff --git a/app/assets/images/external-link-white-12x12.png b/app/assets/images/external-link-white-12x12.png
deleted file mode 100644
index 431face38c5485726db2eed0d000a51603b66732..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 233
zcmeAS@N?(olHy`uVBq!ia0vp^JRr=$1|-8uW1a&k&H|6fVg?3oVGw3ym^DWND5#L^
z5#-CjkUN8cp}3EM;ZrpOL(44&hP){Z3{RyP7>v~!7$n7Kddk!T)#iJ;IEGZ*nsWXi
zZ-at>%f*Gv+y)zYG!DqEJ(cv~*vo3c%{LVus1+-IKCzCW_Q?XnS1Ma3uz5OsOi1fu
zm)<br&4E;hRj)%g%rI4&F#mgw9p8b6jr#8Ot63Q>Vk2!85^4iXmg=q8{fhqrkHlH-
bcZ>|nW!?vw?0$R*Xf=bUtDnm{r-UW|Z4OKM

diff --git a/app/assets/images/external-link-white-24x24.png b/app/assets/images/external-link-white-24x24.png
deleted file mode 100644
index a3b54fe64a8cf581474194702dfd6e0f567d4eb2..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 283
zcmeAS@N?(olHy`uVBq!ia0vp^5+KaM1|%Pp+x`GjoCO|{#S9GG!XV7ZFl!D-g+j7N
zkS_y6?hFQo;ywn3Pt^<zEw>mL@}@8_Je6W#Fji+^kQATkDN_$ryU^3cF{I+wn=89{
z4;%2f2CfQ~+P=;xg6*;aTS$f2dchd;Lg5$AGm};cB>d*n5E61=vo;JUT6~y8>0U>L
za?%_2f(k~#6SFvDvds#%G^lSVsbc-+Rq^kQ%GHLWKb~zYiH&mDeBlvic0*W2UQ7x@
z5dVwT<M&Q(XYk!|hm~oA=AolT2e~WC5BVN258^Us7T*+lXgR}mzazpE><wPO{%>2r
a$8h2DuD}fI;H^N%GI+ZBxvX<aXaWFdk6;u4

diff --git a/app/assets/stylesheets/frontend/global/_links.scss b/app/assets/stylesheets/frontend/global/_links.scss
index fa885ec4106..1b18f98005d 100644
--- a/app/assets/stylesheets/frontend/global/_links.scss
+++ b/app/assets/stylesheets/frontend/global/_links.scss
@@ -16,16 +16,8 @@ a {
   &:focus {
     text-decoration: underline;
   }
-  &[rel="external"] {
-    @include external-link-13-no-hover;
-    @include media(tablet) {
-      @include external-link-19-no-hover;
-    }
-  }
 
   * {
     cursor: pointer;
   }
 }
-
-
diff --git a/app/assets/stylesheets/frontend/helpers/_attachment.scss b/app/assets/stylesheets/frontend/helpers/_attachment.scss
index 47e6550d4fa..4776d0c7a87 100644
--- a/app/assets/stylesheets/frontend/helpers/_attachment.scss
+++ b/app/assets/stylesheets/frontend/helpers/_attachment.scss
@@ -80,9 +80,6 @@ $thumbnail-width: 99px;
   .opendocument-help {
     margin: 0;
     @include ig-core-14;
-    a {
-      @include external-link-14;
-    }
   }
 
   .accessibility-warning {
diff --git a/app/assets/stylesheets/frontend/helpers/_featured-links.scss b/app/assets/stylesheets/frontend/helpers/_featured-links.scss
index 780c577e325..6c052b292be 100644
--- a/app/assets/stylesheets/frontend/helpers/_featured-links.scss
+++ b/app/assets/stylesheets/frontend/helpers/_featured-links.scss
@@ -12,12 +12,5 @@
     @include media(tablet) {
       padding-bottom: $gutter-one-sixth;
     }
-
-    a[rel="external"] {
-      @include external-link-14-bold-no-hover;
-      @include media(tablet) {
-        @include external-link-16-bold-no-hover;
-      }
-    }
   }
 }
diff --git a/app/assets/stylesheets/frontend/helpers/_featured_news.scss b/app/assets/stylesheets/frontend/helpers/_featured_news.scss
index 5d2c96f77c6..fe529c78e02 100644
--- a/app/assets/stylesheets/frontend/helpers/_featured_news.scss
+++ b/app/assets/stylesheets/frontend/helpers/_featured_news.scss
@@ -63,9 +63,6 @@
           padding-top: 0;
           a {
             font-weight: bold;
-            &[rel=external] {
-              @include external-link-19-bold-no-hover;
-            }
           }
         }
         h3 {
@@ -80,4 +77,3 @@
     }
   }
 }
-
diff --git a/app/assets/stylesheets/frontend/helpers/_metadata-list.scss b/app/assets/stylesheets/frontend/helpers/_metadata-list.scss
index ead8d984e8b..cba896eac5e 100644
--- a/app/assets/stylesheets/frontend/helpers/_metadata-list.scss
+++ b/app/assets/stylesheets/frontend/helpers/_metadata-list.scss
@@ -51,13 +51,6 @@
       }
     }
 
-    a[rel="external"] {
-      @include external-link-12;
-      @include media(tablet) {
-        @include external-link-14;
-      }
-    }
-
     .change-notes-title {
       @include media(desktop){
         clear: left;
diff --git a/app/assets/stylesheets/frontend/styleguide/_typography.scss b/app/assets/stylesheets/frontend/styleguide/_typography.scss
index 61202e08605..9a91c724461 100644
--- a/app/assets/stylesheets/frontend/styleguide/_typography.scss
+++ b/app/assets/stylesheets/frontend/styleguide/_typography.scss
@@ -121,32 +121,14 @@
   }
 }
 
-// TODO (@bfirsh): refactor frontend_toolkit external link mixin to work with 
-// white icons: https://github.com/alphagov/govuk_frontend_toolkit/pull/51
-@mixin external-link-white {
-  &:after {
-    background-image: image-url("external-link-white-12x12.png");
-    background-repeat: no-repeat;
-
-    @include device-pixel-ratio() {
-      background-image: image-url("external-link-white-24x24.png");
-      background-size: 12px 400px;
-    }
-  }
-}
-
 @mixin white-links {
   a,
   a:visited,
   a:hover {
     color: $white;
     text-decoration: underline;
-    &[rel="external"] {
-      @include external-link-white;
-    }
   }
   a:active {
     color: $link-active-colour;
   }
 }
-
diff --git a/app/assets/stylesheets/frontend/views/_html-publications.scss b/app/assets/stylesheets/frontend/views/_html-publications.scss
index bd14db8949a..0ac2c1a7c7d 100644
--- a/app/assets/stylesheets/frontend/views/_html-publications.scss
+++ b/app/assets/stylesheets/frontend/views/_html-publications.scss
@@ -280,10 +280,6 @@
           ol+p {
             margin-top: $gutter-one-third;
           }
-
-          a[rel="external"] {
-            @include external-link-14;
-          }
         }
       }
 
diff --git a/app/assets/stylesheets/frontend/views/_organisations.scss b/app/assets/stylesheets/frontend/views/_organisations.scss
index 02cd2df8a6f..d9938dad156 100644
--- a/app/assets/stylesheets/frontend/views/_organisations.scss
+++ b/app/assets/stylesheets/frontend/views/_organisations.scss
@@ -998,9 +998,6 @@
         ul {
           margin-top: $gutter-one-third;
         }
-        a[rel=external] {
-          @include external-link-16-bold-no-hover;
-        }
       }
       .large {
         ul {
diff --git a/app/assets/stylesheets/frontend/views/_world_locations.scss b/app/assets/stylesheets/frontend/views/_world_locations.scss
index 96c12c6435c..86d20df76c8 100644
--- a/app/assets/stylesheets/frontend/views/_world_locations.scss
+++ b/app/assets/stylesheets/frontend/views/_world_locations.scss
@@ -97,13 +97,6 @@
           li {
             list-style: none;
             margin-bottom: $gutter-one-sixth;
-
-            a[rel="external"] {
-              @include external-link-14-bold-no-hover;
-              @include media(tablet) {
-                @include external-link-16-bold-no-hover;
-              }
-            }
           }
         }
         @include media(tablet) {