From 9fb01e4a77f202dba1dd3c4d35b74991cb07a4f0 Mon Sep 17 00:00:00 2001 From: Mike Patrick Date: Fri, 3 Jan 2025 14:33:57 +0000 Subject: [PATCH] Remove all traces of old Sidekiq "worker" naming Sidekiq::Worker was deprecated a while back and [we switched over](https://github.com/alphagov/transition/pull/1704/commits/1817374062f3cccda0e7f6f6777ea301447c988f) to using Sidekiq::Job here and moved this file from app/workers. I assume there's a reason that we kept these bits when we made those changes. Some sort of compatibility issue? Anyway, this setup is now preventing RSpec from running at all on my machine. (I think it's the difference between the naming of the MappingsBatchJob constant and its file.) So I'm hoping that it's not needed anymore. --- app/sidekiq/{mappings_batch_worker.rb => mappings_batch_job.rb} | 2 -- 1 file changed, 2 deletions(-) rename app/sidekiq/{mappings_batch_worker.rb => mappings_batch_job.rb} (87%) diff --git a/app/sidekiq/mappings_batch_worker.rb b/app/sidekiq/mappings_batch_job.rb similarity index 87% rename from app/sidekiq/mappings_batch_worker.rb rename to app/sidekiq/mappings_batch_job.rb index 03ba7a106..8c6001031 100644 --- a/app/sidekiq/mappings_batch_worker.rb +++ b/app/sidekiq/mappings_batch_job.rb @@ -11,5 +11,3 @@ def perform(mappings_batch_id) end end end - -MappingsBatchWorker = MappingsBatchJob