Redefine sidekiq requirement to not install beta version #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, bundler will install version `7.0.0.beta1` of sidekiq as it considers this to be less than `7`. We do not want this to happen. In #84, we changed the requirement from `">= 6.5.12", "< 7"` to `"~> 6.5"`. This has a side effect of some of our applications ending up on an earlier version of sidekiq than `6.5.12` (there was a security fix in `6.5.10`). Therefore in #85 we changed the requirement to be `"> 6.5.10", "< 7"`, however this once again resulted in bundler installing `7.0.0.beta`. Updating the requirements again to be even more explicit, so we always install a version newer than `6.5.12` but never a version that isn't `6.5.x`.
robinjam
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bundler will install version
7.0.0.beta1of sidekiq as it considers this to be less than7. We do not want this to happen.In #84, we changed the requirement from
">= 6.5.12", "< 7"to"~> 6.5". This has a side effect of some of our applications ending up on an earlier version of sidekiq than6.5.12(there was a security fix in6.5.10).Therefore in #85 we changed the requirement to be
"> 6.5.10", "< 7", however this once again resulted in bundler installing7.0.0.beta.Updating the requirements again to be even more explicit, so we always install a version newer than
6.5.12but never a version that isn't6.5.x.This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.