Upgrade to Sidekiq 7 #115
Merged
Upgrade to Sidekiq 7 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidekiq 7.0 no longer uses the `redis` gem, so we should swap to use the new `redis-client` gem.
Support for `redis-namespace` has been removed in Sidekiq 7.0, so we need to stop including it as a dependency.
This makes the changes required for upgrading Sidekiq to version 7.0. Co-authored-by: Callum Knights <callum.knights@digital.cabinet-office.gov.uk> Co-authored-by: George Eaton <george@dxw.com> Co-authored-by: Jon Hallam <jonathan.hallam@digital.cabinet-office.gov.uk> Co-authored-by: Ynda Jas <yndajas@gmail.com>
brucebolt
force-pushed
the
sidekiq-mobbing
branch
from
14e9f1c
to
07c0e81
Compare
In Sidekiq 7, `redis_namespace` is no longer supported. We therefore need to run a migration at the point of upgrading to remove the namespace from existing Redis keys. If we don't run the migration, already queued jobs won't get processed.
brucebolt
force-pushed
the
sidekiq-mobbing
branch
from
07c0e81
to
289da44
Compare
JonathanHallam
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to Sidekiq 7 and releases version 9.0.0 of the gem.
Upgrading to Sidekiq 7 includes a number of breaking changes, which require action to be taken in applications. These steps are detailed in the
CHANGELOG.Trello card