Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-govuk requirement from = 4.18.0 to = 5.0.1 #113

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2024

Updates the requirements on rubocop-govuk to permit the latest version.

Changelog

Sourced from rubocop-govuk's changelog.

5.0.1

  • Disable RSpec/NoExpectationExample for feature and system specs as it false triggers.

5.0.0

  • BREAKING: Update rubocop-rspec to 3.0 which enables by default previously pending cops. See rubocop-rspec's changelog for details.

4.18.0

  • Drop support for Ruby 3.0

4.17.1

  • Update dependencies

4.17.0

  • Apply feature spec exemptions to system specs
  • Update rubocop to 1.63.5
  • Update rubocop-rspec to 2.29.2
  • Update rubocop-ast to 1.31.3

4.16.1

  • Update dependencies

4.16.0

  • Disable Style/MultilineBlockChain
  • Update rubocop-rails to 2.24.1

4.15.0

  • Update rubocop to 1.62.1
  • Update rubocop-ast to 1.31.2
  • Update rubocop-rails to 2.24.0
  • Update rubocop-rspec to 2.27.1

4.14.0

  • Update rubocop to 1.60.2
  • Update rubocop-rails to 2.23.1
  • Update rubocop-rspec to 2.26.1
  • Add Snyk scans to CI pipeline

4.13.0

  • Update rubocop to 1.59.0
  • Update rubocop-ast to 1.30.0

... (truncated)

Commits
  • a1e3489 Merge pull request #400 from alphagov/kevindew-patch-1
  • e46452a Release 5.0.1
  • 1c1ed2a Disable RSpec/NoExpectationExample for feature/system specs
  • 6f199ed Merge pull request #393 from alphagov/new-release
  • 3cfe11c Release 5.0.0
  • f176db6 Update RSpec/Dialect config
  • 993ffa7 Move RSpec/Dialect config to rspec.yml
  • 57aaeed Merge pull request #392 from alphagov/dependabot/bundler/rubocop-rspec-eq-3.0.1
  • 4ec3e56 Add Capybara which was extracted from rubocop-rspec
  • 9a277a8 Use 'RSpec/Dialect' instead of 'RSpec/Capybara/FeatureMethods'
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) to permit the latest version.
- [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md)
- [Commits](alphagov/rubocop-govuk@v4.18.0...v5.0.1)

---
updated-dependencies:
- dependency-name: rubocop-govuk
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jun 26, 2024
Copy link

@sengi sengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@brucebolt brucebolt force-pushed the dependabot/bundler/rubocop-govuk-eq-5.0.1 branch from 7c751b6 to 3c8e8be Compare June 27, 2024 10:20
This test contains no expectation or assertion. The intention may have
been that no error is raised, so explicitly adding an expectation for
that.
@brucebolt brucebolt force-pushed the dependabot/bundler/rubocop-govuk-eq-5.0.1 branch from 3c8e8be to 1464de9 Compare June 27, 2024 10:24
@brucebolt brucebolt merged commit 2e5127a into main Jun 27, 2024
17 checks passed
@brucebolt brucebolt deleted the dependabot/bundler/rubocop-govuk-eq-5.0.1 branch June 27, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants