Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconnect_attempts not working with Redis 4.8 #108

Merged
merged 1 commit into from
Jun 11, 2024

Commits on Jun 11, 2024

  1. Fix reconnect_attempts not working with Redis 4.8

    Our apps are currently using Redis 4.8 due to a constraint from the
    version of Sidekiq we are using.
    
    However in a previous commit, we used Redis 5 syntax to specify a new
    value for `reconnect_attempts`. This is not compatible with Redis 4.8.
    
    Therefore updating the syntax to match that expected for Redis 4.8 [1]
    and explicitly stating the version of Redis we expect (since Redis 5
    doesn't support the legacy syntax).
    
    1: https://github.com/redis/redis-rb/tree/v4.8.1?tab=readme-ov-file#reconnections
    brucebolt committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    32def77 View commit details
    Browse the repository at this point in the history